8000 NOISSUE - Remove unknown Bootstrap requests by dborovcanin · Pull Request #1210 · absmach/supermq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NOISSUE - Remove unknown Bootstrap requests #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Conversation

dborovcanin
Copy link
Collaborator

Signed-off-by: dusanb94 dusan.borovcanin@mainflux.com

What does this do?

This pull request removes unknown Bootstrap requests code, DB table, and API.

List any changes that modify/break current functionality

Storing unsuccessful bootstrap requests and code related to it is removed.

Have you included tests for your changes?

Yes, tests are updated accordingly.

Did you document any new/modified functionality?

Yes, docs are updated, as well.

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
@codecov-commenter
Copy link
codecov-commenter commented Jun 26, 2020

Codecov Report

Merging #1210 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
- Coverage   77.04%   77.02%   -0.02%     
==========================================
  Files         104      104              
  Lines        6934     6868      -66     
==========================================
- Hits         5342     5290      -52     
+ Misses       1206     1196      -10     
+ Partials      386      382       -4     
Impacted Files Coverage Δ
bootstrap/api/responses.go 100.00% <ø> (ø)
bootstrap/api/transport.go 93.10% <ø> (-0.57%) ⬇️
bootstrap/postgres/configs.go 70.79% <ø> (+0.69%) ⬆️
bootstrap/api/endpoint.go 100.00% <100.00%> (ø)
bootstrap/postgres/init.go 94.02% <100.00%> (+0.80%) ⬆️
bootstrap/service.go 78.12% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5c763...58cbc6a. Read the comment docs.

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
@dborovcanin dborovcanin marked this pull request as ready for review June 26, 2020 11:16
@dborovcanin dborovcanin requested a review from a team as a code owner June 26, 2020 11:16
Copy link
Contributor
@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 8d33285 into absmach:master Jun 26, 2020
manuio pushed a commit that referenced this pull request Oct 12, 2020
* Remove unknown Bootstrap requests

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* Update docs

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* Fix migrations

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
@dborovcanin dborovcanin deleted the fix-bs branch February 17, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0