8000 NOISSUE - Remove twin mqtt related obsolete var and fix es-redis address by darkodraskovic · Pull Request #1213 · absmach/supermq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NOISSUE - Remove twin mqtt related obsolete var and fix es-redis address #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2020
Merged

NOISSUE - Remove twin mqtt related obsolete var and fix es-redis address #1213

merged 1 commit into from
Jul 2, 2020

Conversation

darkodraskovic
Copy link
Contributor

Signed-off-by: Darko Draskovic darko.draskovic@gmail.com

What does this do?

Removes an obsolete leftover variable related to mqtt notification publishing (removed feature, replaced with NATS publishing) and fixes redis address so twins service can reach redis cache.

List any changes that modify/break current functionality

N/A

@darkodraskovic darkodraskovic requested a review from a team as a code owner July 2, 2020 14:39
manuio
manuio previously approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor
@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
codecov-commenter commented Jul 2, 2020 •
edited
Loading

Codecov Report

Merging #1213 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1213   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files         104      104           
  Lines        6868     6868           
=======================================
  Hits         5290     5290           
  Misses       1196     1196           
  Partials      382      382

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b7fd8...a4ee672. Read the comment docs.

mteodor
mteodor previously approved these changes Jul 2, 2020
View reviewed changes
@darkodraskovic
Remove twin mqtt related obsolete var and fix es-redis address
a4ee672 
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
@darkodraskovic darkodraskovic dismissed stale reviews from mteodor and manuio via a4ee672 July 2, 2020 15:41
drasko
drasko approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor
@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit a7eee53 into absmach:master Jul 2, 2020
@blokovi
Copy link
Contributor
blokovi commented Jul 2, 2020

You can also delete MONGO_INITDB_DATABASE in .env and docker-compose.yml

MONGO_INITDB_DATABASE is only used if you have scripts in /docker-entrypoint-initdb.d/ since there is no CREATE DATABASE x like in SQL land; you can just use a database and it will exist.
(source)

And this is tested in kubernetes deployment (https://github.com/mainflux/devops/pull/52/f)

@darkodraskovic darkodraskovic deleted the twins-env branch August 10, 2020 10:46
manuio pushed a commit that referenced this pull request Oct 12, 2020
@darkodraskovic
Remove twin mqtt related obsolete var and fix es-redis address (#1213)
4668ea3 
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drasko drasko drasko approved these changes

@dborovcanin dborovcanin dborovcanin approved these changes

@mteodor mteodor mteodor left review comments

@manuio manuio manuio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@darkodraskovic @codecov-commenter @blokovi @drasko @mteodor @manuio @dborovcanin
0