8000 NOISSUE - remove owner id from user table and object by mteodor · Pull Request #1303 · absmach/supermq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

NOISSUE - remove owner id from user table and object #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2020
Merged

NOISSUE - remove owner id from user table and object #1303

merged 2 commits into from
Dec 15, 2020

Conversation

mteodor
Copy link
Contributor
@mteodor mteodor commented Dec 15, 2020

What does this do?

Removing owner id from user object as no needed

@mteodor
remove owner id
5dbce27 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor mteodor requested a review from a team as a code owner December 15, 2020 11:01
@codecov-io
Copy link
codecov-io commented Dec 15, 2020 •
edited
Loading

Codecov Report

Merging #1303 (97c386a) into master (9864b27) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
- Coverage   64.65%   64.64%   -0.01%     
==========================================
  Files         117      117              
  Lines        8029     8027       -2     
==========================================
- Hits         5191     5189       -2     
  Misses       2383     2383              
  Partials      455      455
Impacted Files Coverage Δ
users/postgres/init.go 93.10% <ø> (-0.23%) ⬇️
users/postgres/users.go 52.10% <ø> (ø)
users/users.go 78.94% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9864b27...97c386a. Read the comment docs.

@mteodor
remove owner id
97c386a 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
manuio
manuio approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor
@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

drasko
drasko approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor
@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 18dd896 into absmach:master Dec 15, 2020
@mteodor mteodor deleted the remove-user branch September 13, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drasko drasko drasko approved these changes

@manuio manuio manuio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mteodor @codecov-io @drasko @manuio
0