8000 NOISSUE - Support disabling Email Agent authentication by dborovcanin · Pull Request #1356 · absmach/supermq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NOISSUE - Support disabling Email Agent authentication #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2021

Conversation

dborovcanin
Copy link
Collaborator

Signed-off-by: dusanb94 dusan.borovcanin@mainflux.com

What does this do?

This pull request adds support for disabling authentication for the Mainflux Email Agent. It also adds support for the CRAM-MD5 authentication method alongside Basic Auth.

Which issue(s) does this PR fix/relate to?

There is no such issue.

List any changes that modify/break current functionality

If the username is not present in the agent configuration, no authorization will be used.

Have you included tests for your changes?

No.

Did you document any new/modified functionality?

Yes.

@dborovcanin dborovcanin requested a review from a team as a code owner February 5, 2021 14:14
@dborovcanin dborovcanin changed the title NOISSUE - Support disabling Emailer authentication NOISSUE - Support disabling Email Agent authentication Feb 5, 2021
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Copy link
Contributor
@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit 13c426c into absmach:master Feb 8, 2021
fbugarski pushed a commit to fbugarski/mainflux that referenced this pull request Mar 8, 2021
* Fix mailer configuration

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* Remove unused Driver option

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* Add Email Agent README

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
@dborovcanin dborovcanin deleted the fix-emailer branch June 13, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0