8000 NOISSUE - Added missing endpoints for users service by fbugarski · Pull Request #1372 · absmach/supermq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NOISSUE - Added missing endpoints for users service #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

fbugarski
Copy link
Contributor

Signed-off-by: Filip Bugarski filipbugarski@gmail.com

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.

What does this do?

Which issue(s) does this PR fix/relate to?

Put here Resolves #XXX to auto-close the issue that your PR fixes (if such)

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

Signed-off-by: Filip Bugarski <filipbugarski@gmail.com>
@fbugarski fbugarski requested a review from a team as a code owner February 25, 2021 16:04
@@ -51,7 +51,7 @@ http {
server_name localhost;

# Proxy pass to users service
location ~ ^/(users|tokens) {
location ~ ^/(users|tokens|password|gruops) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you misspelled groups here

Signed-off-by: Filip Bugarski <filipbugarski@gmail.com>
Copy link
Contributor
@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blokovi blokovi merged commit 56d04cd into absmach:master Feb 25, 2021
fbugarski added a commit to fbugarski/mainflux that referenced this pull request Mar 8, 2021
* Added missing endpoints for user's service

Signed-off-by: Filip Bugarski <filipbugarski@gmail.com>

* Type fix

Signed-off-by: Filip Bugarski <filipbugarski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0