8000 MF-942 - Simplify email template mapping by drasko · Pull Request #943 · absmach/supermq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MF-942 - Simplify email template mapping #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

drasko
Copy link
Contributor
@drasko drasko commented Nov 8, 2019

Signed-off-by: Drasko DRASKOVIC drasko.draskovic@gmail.com

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.

What does this do?

Which issue(s) does this PR fix/relate to?

Resolves #942

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

Resolves absmach#942.

Signed-off-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
@drasko drasko requested a review from mteodor November 8, 2019 18:14
@drasko drasko requested a review from a team as a code owner November 8, 2019 18:14
@codecov-io
Copy link

Codecov Report

Merging #943 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #943      +/-   ##
==========================================
+ Coverage   82.43%   82.47%   +0.03%     
==========================================
  Files          75       75              
  Lines        5244     5244              
==========================================
+ Hits         4323     4325       +2     
+ Misses        661      659       -2     
  Partials      260      260
Impacted Files Coverage Δ
things/service.go 90.44% <0%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841b943...f55ccc8. Read the comment docs.

@chombium
Copy link
Collaborator
chombium commented Nov 9, 2019

@drasko, @mteodor it looks to me that this PR overlaps with #944. Could we maybe close this as the changes introduced in this one are already in #944?

@drasko
Copy link
Contributor Author
drasko commented Nov 10, 2019

Duplicate of #944

@drasko drasko marked this as a duplicate of #944 Nov 10, 2019
@drasko drasko closed this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E-mail template usage is confusing
4 participants
0