8000 Improvements based on other forks by acook · Pull Request #2 · acook/OfficeKeyFix · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improvements based on other forks #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 6, 2024
Merged

Improvements based on other forks #2

merged 7 commits into from
May 6, 2024

Conversation

acook
Copy link
Owner
@acook acook commented May 6, 2024
  • deregister office key on its own
  • reduce duplication so that more keys can be added
  • fix potential issues on configurations that use different paths for windows
  • update visual studio solution to latest

acook added 6 commits May 5, 2024 22:22
Now changes to the offendingkeys list will automatically be detected

This also includes a hack which deregisters the key itself

Jory's version here: https://github.com/jorystewart/OfficeKeyFix/blob/main/main.cpp
Fixed length arrays in C++ can auto-detect their length, so we can leave it out of the initializer

Adding the null inspired by commit cafb206 from @Vechro.
Doing so may even cause issues on some configurations

Inspired by commit cafb206 from @Vechro
So the command window doesn't stay open after completing its task
Previously just in commit messages
@acook acook merged commit f5675e5 into main May 6, 2024
@acook acook deleted the improvements branch May 6, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0