Fix wrong PR URL in logs and log closed PR labels #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, an URL with `/pulls/` appeared in the logs, when the correct one is with `/pull/` instead. It turns out the GitHub API returns the browsable URL in the response, so I use that one instead.
|
@yajo could you add a changelog entry in the readme? |
Bots tend to mark PRs as closed instead of merged, but add some label that indicates such state. Let's log labels to have that information at hand.
d5b017a to
fbcbf99
Compare
|
Done, thanks. I've put the date of today optimistically 😇. |
1 similar comment
|
Ok, merged and tagged. It should land on pypi soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, an URL with
/pulls/appeared in the logs, when the correct one is with/pull/instead.It turns out the GitHub API returns the browsable URL in the response, so I use that one instead.
Also, bots tend to mark PRs as closed instead of merged, but add some label that indicates such state. Let's log labels to have that information at hand.