simplify tool responses #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- start removing additional fields
- simplify queries list
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies tool responses by removing additional fields and streamlining the queries list. Key changes include:
- Using json.dumps for formatted printing in output functions.
- Simplifying the GraphQL response by narrowing the "subjects" field to unique dataset urns.
- Removing unneeded intermediate variables for cleaner code flow.
Files not reviewed (2)
- src/mcp_server_datahub/gql/entity_details.gql: Language not supported
- src/mcp_server_datahub/gql/queries.gql: Language not supported
Comment on lines
+188
to
196
| updated_subjects: OrderedSet[str] = OrderedSet() | ||
| for subject in query["subjects"]: | ||
| with contextlib.suppress(KeyError): | ||
| updated_subjects.add(subject["dataset"]["urn"]) | ||
| query["subjects"] = list(updated_subjects) | ||
|
|
||
| return result | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] Consider extracting the logic for deduplicating subjects into a separate helper function to improve readability and maintainability.
Suggested change
| updated_subjects: OrderedSet[str] = OrderedSet() | |
| for subject in query["subjects"]: | |
| with contextlib.suppress(KeyError): | |
| updated_subjects.add(subject["dataset"]["urn"]) | |
| query["subjects"] = list(updated_subjects) | |
| return result | |
| query["subjects"] = _deduplicate_subjects(query["subjects"]) | |
| return result | |
| def _deduplicate_subjects(subjects: list[dict]) -> list[str]: | |
| """ | |
| Deduplicates the dataset URNs from the subjects list. | |
| Args: | |
| subjects (list[dict]): The list of subjects containing dataset information. | |
| Returns: | |
| list[str]: A deduplicated list of dataset URNs. | |
| """ | |
| updated_subjects: OrderedSet[str] = OrderedSet() | |
| for subject in subjects: | |
| with contextlib.suppress(KeyError): | |
| updated_subjects.add(subject["dataset"]["urn"]) | |
| return list(updated_subjects) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.