8000 [smallfix] Refactor the string manipulation by bitfriend · Pull Request #2999 · acterglobal/a3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[smallfix] Refactor the string manipulation #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 22, 2025
Merged

[smallfix] Refactor the string manipulation #2999

merged 7 commits into from
May 22, 2025

Conversation

bitfriend
Copy link
Contributor

This PR is just only mechanical transition.

  • Replace .to_owned() with proper .clone()
  • Replace .to_string() with proper .clone() or .to_owned()
  • Replace .to_string() with ToString::to_string

@bitfriend bitfriend added rust minor This is a changeset with little need for review. labels May 21, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Product May 21, 2025
@codecov Codecov
Copy link
codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 39.01515% with 161 lines in your changes missing coverage. Please review.

Project coverage is 41.30%. Comparing base (115b581) to head (4806deb).
Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
native/acter/src/api/verification.rs 0.00% 58 Missing ⚠️
native/core/src/events/common/object_reference.rs 6.66% 14 Missing ⚠️
native/core/src/activities.rs 13.33% 13 Missing ⚠️
native/acter/src/api/room.rs 0.00% 8 Missing ⚠️
native/acter/src/api/timeline/item.rs 46.66% 8 Missing ⚠️
native/core/src/models/comments.rs 41.66% 7 Missing ⚠️
native/acter/src/api/room/preview.rs 0.00% 6 Missing ⚠️
native/acter/src/api/utils.rs 50.00% 6 Missing ⚠️
native/acter/src/api/tasks.rs 33.33% 4 Missing ⚠️
native/core/src/models/attachments.rs 63.63% 4 Missing ⚠️
... and 18 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2999      +/-   ##
==========================================
- Coverage   41.71%   41.30%   -0.41%     
==========================================
  Files         884      888       +4     
  Lines       55705    55952     +247     
==========================================
- Hits        23236    23111     -125     
- Misses      32469    32841     +372
Flag Coverage Δ
integration-test 48.85% <33.73%> (-1.49%) ⬇️
unittest 31.40% <20.86%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitfriend bitfriend marked this pull request as ready for review May 22, 2025 07:07
@bitfriend bitfriend merged commit 48a3a12 into acterglobal:main May 22, 2025
18 of 23 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Recently Done in Product May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
minor This is a changeset with little need for review. rust
Projects
Product
Status: Recently Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bitfriend
0