Support RedHat/RHEL as a valid target #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: William Stearns <3538265+william-stearns@users.noreply.github.com>
0x6d6f7468
reviewed
May 13, 2025
There was a problem hiding this comment.
Changes seem fine. Tested on a local RHEL VM by manually applying changes and running the installer. One thing that I noticed while testing was that the system patching step was hiding progress from the terminal. Not sure if that's a RHEL thing or something in the installer, but either way it's probably a refinement thing for another day.
lisaSW
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AC-Hunter and Rita's ansible installer did not originally support RedHat/RHEL as an install target because of a conflict between docker and RHEL 9.x. That conflict does not appear to exist any more. Hermon has confirmed that the install works with these changes.