8000 Actions Cache Granular Control Implementation by kotewar · Pull Request #1006 · actions/cache · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Actions Cache Granular Control Implementation #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 94 commits into from
Dec 15, 2022
Merged

Actions Cache Granular Control Implementation #1006

merged 94 commits into from
Dec 15, 2022

Conversation

kotewar
Copy link
Contributor
@kotewar kotewar commented Nov 30, 2022 •
edited
Loading

Description

To address the granular control asks from our users, we have tackled the 4 use cases in this PR.

We added two new actions

  1. restore/action.yml - to only restore cache
  2. save/action.yml - to only save cache
    3. Fail on cache miss (can be handled by workflow conditions)
    4. Save cache on failure (can be handled by workflow conditions using the new action)

Motivation and Context

This will grant our users more control - especially in cases where they only want to restore or save cache explicitly.

How Has This Been Tested?

Testing right now, will update with new workflows for the same.

Screenshots (if appropriate):

NA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs) - will be done in subsequent PRs.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

malob and others added 19 commits February 21, 2022 14:59
@github-actions github-actions bot requested a review from Phantsure November 30, 2022 08:18
@kotewar kotewar marked this pull request as ready for review November 30, 2022 10:57
@kotewar kotewar requested a review from a team as a code owner November 30, 2022 10:57
@kotewar kotewar requested a review from tanuj077 December 1, 2022 05:48
kotewar and others added 20 commits December 12, 2022 18:50
@kotewar @bishal-pdMSFT
Update restore/action.yml
29d6c7a 
Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com>
@kotewar @bishal-pdMSFT
Update restore/action.yml
87a7d01 
Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com>
@kotewar
Added more assertions as values can't be checked
4070447
@kotewar
Removed unused code
1ddc491
@kotewar
Merge remote-tracking branch 'origin/releases/v3-beta' into 700-actio… 
…nscache-granular-cache-control
@kotewar
Merged beta branch and resolved conflicts
075ad79
@kotewar
Merge remote-tracking branch 'origin/700-actionscache-granular-cache-…
adecab4 
…control' into kotewar/readme-updates-for-granular-control
@kotewar
Added save readme
9d445b2
@kotewar
Updates to save readme
81aaae0
@kotewar
Renamed output
c8d01fa
@kotewar
Merge remote-tracking branch 'origin/700-actionscache-granular-cache-…
8031e40 
…control' into kotewar/readme-updates-for-granular-control
@kotewar
Added cache hit info in readme
65057ce
@kotewar @bishal-pdMSFT
Update restore/README.md
44df5ab 
Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com>
@kotewar @bishal-pdMSFT
Update restore/README.md
d5c9496 
Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com>
@kotewar @bishal-pdMSFT
Update restore/README.md
c11ac6c 
Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com>
@kotewar @bishal-pdMSFT
Update save/README.md
fb5b333 
Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com>
@kotewar @bishal-pdMSFT
Update save/README.md
686bf42 
Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com>
@kotewar
Removed verbose statements
766d825
@kotewar
Repositioned new actions introduction
56e9564
@kotewar
Added test case for restore state
930f080
@kotewar kotewar merged commit ed5e94a into releases/v3-beta Dec 15, 2022
@kotewar kotewar deleted the 700-actionscache-granular-cache-control branch December 19, 2022 03:55
@mikelane mikelane mentioned this pull request Dec 22, 2022
Merged
estahn pushed a commit to estahn/k8s-image-swapper that referenced this pull request Jan 1, 2023
@semantic-release-bot
chore(release): 1.4.0 [skip ci]
0ddfc7b 
## [1.4.0](v1.3.3...v1.4.0) (2023-01-01)

### 👷 Build System

* **deps-dev:** Bump @semantic-release/changelog from 6.0.1 to 6.0.2 ([#404](#404)) ([ee56dbc](ee56dbc)), closes [#276](#276) [#276](#276) [#272](#272) [#275](#275) [#273](#273) [#274](#274) [#271](#271) [#270](#270) [#269](#269) [#268](#268) [#267](#267)

### 🎉 Features

* add custom tags to created ECR repositories ([#191](#191)) ([9849df2](9849df2))

### 📝 Documentation

* fix
341A
 indentation ([b00c57e](b00c57e))

### ⬆️ Dependencies

* **deps:** Bump actions/cache from 3.0.11 to 3.2.1 ([#417](#417)) ([7e7eb8f](7e7eb8f)), closes [actions/cache#1039](actions/cache#1039) [actions/cache#1023](actions/cache#1023) [actions/cache#959](actions/cache#959) [actions/cache#960](actions/cache#960) [actions/cache#963](actions/cache#963) [actions/cache#961](actions/cache#961) [actions/cache#976](actions/cache#976) [actions/cache#971](actions/cache#971) [actions/cache#979](actions/cache#979) [actions/cache#986](actions/cache#986) [actions/cache#981](actions/cache#981) [actions/cache#997](actions/cache#997) [actions/cache#998](actions/cache#998) [actions/cache#1005](actions/cache#1005) [actions/cache#1007](actions/cache#1007) [actions/cache#1013](actions/cache#1013) [actions/cache#1004](actions/cache#1004) [actions/cache#1014](actions/cache#1014) [actions/cache#1008](actions/cache#1008) [actions/cache#1026](actions/cache#1026) [actions/cache#929](actions/cache#929) [actions/cache#1035](actions/cache#1035) [actions/cache#959](actions/cache#959) [actions/cache#979](actions/cache#979) [actions/cache#1013](actions/cache#1013) [actions/cache#1026](actions/cache#1026) [actions/cache#929](actions/cache#929) [actions/cache#1006](actions/cache#1006) [#1023](https://github.com/estahn/k8s-image-swapper/issues/1023) [#1039](https://github.com/estahn/k8s-image-swapper/issues/1039) [#1035](https://github.com/estahn/k8s-image-swapper/issues/1035) [#929](https://github.com/estahn/k8s-image-swapper/issues/929) [#1026](https://github.com/estahn/k8s-image-swapper/issues/1026) [#1008](https://github.com/estahn/k8s-image-swapper/issues/1008) [#1014](https://github.com/estahn/k8s-image-swapper/issues/1014) [#1004](https://github.com/estahn/k8s-image-swapper/issues/1004)
* **deps:** Bump actions/setup-python from 4.3.0 to 4.3.1 ([#406](#406)) ([16da762](16da762)), closes [actions/setup-python#559](actions/setup-python#559) [actions/setup-python#511](actions/setup-python#511) [actions/setup-python#558](actions/setup-python#558) [#559](#559) [#558](#558) [#549](#549) [#546](#546) [#545](#545) [#535](#535) [#510](#510) [#511](#511) [#520](#520)
* **deps:** Bump actions/setup-python from 4.3.1 to 4.4.0 ([#418](#418)) ([77872f8](77872f8)), closes [actions/setup-python#566](actions/setup-python#566) [#567](#567) [#569](#569) [#566](#566)
* **deps:** Bump github.com/aws/aws-sdk-go from 1.44.146 to 1.44.152 ([#403](#403)) ([9db51fd](9db51fd)), closes [#4652](https://github.com/estahn/k8s-image-swapper/issues/4652) [#4650](https://github.com/estahn/k8s-image-swapper/issues/4650) [#4648](https://github.com/estahn/k8s-image-swapper/issues/4648) [#4647](https://github.com/estahn/k8s-image-swapper/issues/4647) [#4646](https://github.com/estahn/k8s-image-swapper/issues/4646) [#4644](https://github.com/estahn/k8s-image-swapper/issues/4644) [#4639](https://github.com/estahn/k8s-image-swapper/issues/4639)
* **deps:** Bump github.com/aws/aws-sdk-go from 1.44.152 to 1.44.157 ([#411](#411)) ([2188432](2188432)), closes [#4658](https://github.com/estahn/k8s-image-swapper/issues/4658) [#4657](https://github.com/estahn/k8s-image-swapper/issues/4657) [#4656](https://github.com/estahn/k8s-image-swapper/issues/4656) [#4654](https://github.com/estahn/k8s-image-swapper/issues/4654) [#4653](https://github.com/estahn/k8s-image-swapper/issues/4653)
* **deps:** Bump github.com/aws/aws-sdk-go from 1.44.157 to 1.44.162 ([#415](#415)) ([f70fcd9](f70fcd9)), closes [#4666](https://github.com/estahn/k8s-image-swapper/issues/4666) [#4665](https://github.com/estahn/k8s-image-swapper/issues/4665) [#4663](https://github.com/estahn/k8s-image-swapper/issues/4663) [#4661](https://github.com/estahn/k8s-image-swapper/issues/4661) [#4660](https://github.com/estahn/k8s-image-swapper/issues/4660)
* **deps:** Bump github.com/aws/aws-sdk-go from 1.44.162 to 1.44.167 ([#419](#419)) ([f8b91fe](f8b91fe)), closes [#4671](https://github.com/estahn/k8s-image-swapper/issues/4671) [#4670](https://github.com/estahn/k8s-image-swapper/issues/4670) [#4669](https://github.com/estahn/k8s-image-swapper/issues/4669) [#4668](https://github.com/estahn/k8s-image-swapper/issues/4668) [#4667](https://github.com/estahn/k8s-image-swapper/issues/4667)
* **deps:** Bump github.com/gruntwork-io/terratest from 0.41.3 to 0.41.4 ([#402](#402)) ([16dde07](16dde07)), closes [#1208](https://github.com/estahn/k8s-image-swapper/issues/1208)
* **deps:** Bump github.com/gruntwork-io/terratest from 0.41.4 to 0.41.6 ([#409](#409)) ([9fc87df](9fc87df)), closes [#1214](https://github.com/estahn/k8s-image-swapper/issues/1214) [#1198](https://github.com/estahn/k8s-image-swapper/issues/1198)
* **deps:** Bump github.com/gruntwork-io/terratest from 0.41.6 to 0.41.7 ([#420](#420)) ([9ab97f2](9ab97f2)), closes [gruntwork-io/terratest#1217](gruntwork-io/terratest#1217) [#1217](https://github.com/estahn/k8s-image-swapper/issues/1217)
* **deps:** Bump goreleaser/goreleaser-action from 3.1.0 to 4.1.0 ([#414](#414)) ([e963ba1](e963ba1)), closes [goreleaser/goreleaser-action#382](goreleaser/goreleaser-action#382) [goreleaser/goreleaser-action#366](goreleaser/goreleaser-action#366) [goreleaser/goreleaser-action#379](goreleaser/goreleaser-action#379) [goreleaser/goreleaser-action#383](goreleaser/goreleaser-action#383) [goreleaser/goreleaser-action#366](goreleaser/goreleaser-action#366) [goreleaser/goreleaser-action#379](goreleaser/goreleaser-action#379) [goreleaser/goreleaser-action#370](goreleaser/goreleaser-action#370) [#374](#374) [#372](#372) [#373](#373) [#383](#383) [#366](#366) [#382](#382) [#370](#370)
* **deps:** Bump k8s.io/api from 0.25.4 to 0.26.0 ([#407](#407)) ([d13bf5e](d13bf5e)), closes [#111023](https://github.com/estahn/k8s-image-swapper/issues/111023) [#113375](https://github.com/estahn/k8s-image-swapper/issues/113375) [#113186](https://github.com/estahn/k8s-image-swapper/issues/113186)
* **deps:** Bump k8s.io/client-go from 0.25.4 to 0.26.0 ([#410](#410)) ([bcc56b5](bcc56b5)), closes [#113797](https://github.com/estahn/k8s-image-swapper/issues/113797) [#111023](https://github.com/estahn/k8s-image-swapper/issues/111023) [#113826](https://github.com/estahn/k8s-image-swapper/issues/113826) [#113375](https://github.com/estahn/k8s-image-swapper/issues/113375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdce8p cdce8p cdce8p left review comments

@bishal-pdMSFT bishal-pdMSFT 6418 bishal-pdMSFT approved these changes

@Phantsure Phantsure Awaiting requested review from Phantsure

@tanuj077 tanuj077 Awaiting requested review from tanuj077

Assignees

@kotewar kotewar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kotewar @bishal-pdMSFT @cdce8p @Phantsure @malob @tanuj077
0