Add only-issue-types option to filter issues by type
#1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new option ("only-issue-types") to filter issues by their type as part of the stale process.
- Adds a new filter option in the issues processor options and corresponding enum.
- Integrates issue type filtering within the processor with tests and documentation updates.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/interfaces/issues-processor-options.ts | Added an optional property for filtering by issue type. |
| src/interfaces/issue.ts | Added a new property for holding the issue type. |
| src/enums/option.ts | Added the OnlyIssueTypes enum option. |
| src/classes/issues-processor.ts | Updated logic to filter issues based on allowed types and log skipped ones. |
| src/classes/issue.ts | Set issue_type based on provided issue information. |
| action.yml | Added a new input parameter for only-issue-types. |
| tests/only-issue-types.spec.ts | Added tests validating the behavior of filtering on issue types. |
| tests/functions/generate-issue.ts | Extended the generateIssue function to support issue_type. |
| README.md | Updated documentation to include details about the new option. |
Comments suppressed due to low confidence (1)
src/classes/issues-processor.ts:261
- The log message uses '$$type' which appears to be a typo or unclear wording; consider replacing it with a clearer reference such as 'issue'.
`Skipping this $$type because its type ('${ issue.issue_type }') is not in onlyIssueTypes (${allowedTypes.join(', ')})`
andig
reviewed
May 19, 2025
Co-authored-by: andig <cpuidle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Tries to implement a filter based on the issue type on issues as described in #1187. I tried following the suggestions in #1187 (comment). Copilot did help me, though I reviewed everything manually and made sure to follow the instructions in the contribution guide. Hopefully I didn't miss anything …
Related issue:
closes #1187
Check list: