Throughput Output Formatting Improvements, main branch (2025.06.06.) #1009
Conversation
|
You mean the padding is different @krasznaa? |
It uses an AM/PM formalism with the logger that was created with std::unique_ptr<const traccc::Logger> logger = traccc::getDefaultLogger(
"ThroughputExample", traccc::Logging::Level::INFO);But then all the loggers cloned from this one use a 24-hour formalism. So something seemingly is not getting cloned/copied correctly, but rather getting default-initialized on the clones. (But this is just an educated guess.) |
|
I'll need to look into this. |
1908476 to
8c979ef
Compare
|
In the meanwhile this PR could be reviewed as-is. The printouts have the same behaviour in the current main branch already, that's not coming from this PR. |
8c979ef to
4b42622
Compare
|
While working on #1007 and #1008, I was reminded that the outputs from the throughput applications could do with a bit of an improvement. After these updates, the applications output everything using
traccc::Loggerbeside the few lines printed by Detray. Along the lines of:And:
Note how the "non-cloned"
traccc::Loggerobject in thethroughput_st(...)andthroughput_mt(...)functions uses a slightly different formatting at the end of the logs. 🤔 Which makes me think that Acts::Logger::clone(...) is not working correctly at the moment. 🤔 But that's not a burning issue right now...Still, @paulgessinger, it may be worth a look at one point.