Jagged Vector Copy Fix, v1.3.0-patches branch (2024.02.12.) #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just for reference, we do this regularly in the ACTS core repository. I suppose the difference is that we tag on dedicated branches there. Should we discuss this tomorrow @krasznaa? |
Copying data into a buffer that is "too big" is allowed, even if not encouraged. While too small buffer targets should be correctly identified by the copy code, with an exception thrown.
Previously it didn't allow copies into bigger-than-necessary fixed-sized buffers, and didn't correctly identify too small resizable buffers.
e665bcd to
5ad8b41
Compare
|
After talking to @paulgessinger a bit, I renamed the "patch branch" to something that I also like a bit more, but other than that we agreed to go ahead with the simple setup that I discussed with @stephenswat yesterday. 🤔 So, let's try this for now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to have a new tag with #264 included in it, but making
v1.4.0so quickly afterv1.3.0seemed to be a poor solution. 🤔 So I thought I'd try it out, how we may want to handle patches to older releases in the future. In case we ever get into such a working mode. 🤔 (Admittedly I was thinking about this since a while, so I took this opportunity to try this out.)I went with the branch naming used by ROOT. But you should speak up, if you dislike this for some reason.
As you can see, the new release will be called
v1.3.1. With the separatev1.3.0-patchesbranch, I could update the project version to be1.3.1already. 😉