forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] master from prebid:master #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mefjush
pushed a commit
that referenced
this pull request
May 21, 2024
* KRKPD-1083: Refactor and expand testing (#31) * Refactor the Kargo adapter testing to be more comprehensive and include testing of invalid inputs * Fix the window size test to pull data from the browser instead of hardcoded values * Remove a duplicate test * unhook triggerPixel after tests * fixes circleci failure * Update the localStorage non-functional test In FireFox, having localStorage.getItem throw an error isn't working so the test was updated to not have a valid localStorage value to pass on FireFox. * Restore the bidderSettings following testing --------- Co-authored-by: William Klausmeyer <klawil@users.noreply.github.com> Co-authored-by: “Nick <“nick.llerandi”@kargo.com> Co-authored-by: William Klausmeyer <willyk95@gmail.com>
pull bot
pushed a commit
that referenced
this pull request
May 21, 2024
* KRKPD-1083: Refactor and expand testing (#31) * Refactor the Kargo adapter testing to be more comprehensive and include testing of invalid inputs * Fix the window size test to pull data from the browser instead of hardcoded values * Remove a duplicate test * unhook triggerPixel after tests * fixes circleci failure * Update the localStorage non-functional test In FireFox, having localStorage.getItem throw an error isn't working so the test was updated to not have a valid localStorage value to pass on FireFox. * Restore the bidderSettings following testing --------- Co-authored-by: William Klausmeyer <klawil@users.noreply.github.com> Co-authored-by: “Nick <“nick.llerandi”@kargo.com> Co-authored-by: William Klausmeyer <willyk95@gmail.com>
westerschmal
pushed a commit
that referenced
this pull request
Jun 24, 2025
…rameters (prebid#13122) * V 0 29 (#31) * AGT-403: Add adType 891C parameter to payload in report * AGT-403: Test for partner report, adType parameter * AGT-403: Test refactoring * AGT-403: Documentation updated * IntentIq Analytics Module: adUnitCode or placemetId to report (#9) * AGT-446: adUnitCode or placemetId to report * AGT-446: Description of changes, example * AGT-446: Fix documentation * AGT-446: Changes after review * Agt 409 full url in prebid modules (#8) * add sync * update full url * set url param * fix comment * fix issue fix sync mode * update url * update full url * add test * move browser_blacklist (#10) * add is optedOut (#11) * update date in FPD after sync (#12) * update sync logic for new user (#13) * fix unit tests * change version name * IntentIq ID: Support sourceMetaData and sourceMetaDataExternal (#17) * AGT-453: Support sourceMetaData * AGT-453: sourceMetaDataExternal * AGT-453: Documentation * AGT-453: Changes after review * AGT-453: Fix doc * Fix doc * AGT-453: Fix test * update test * update endpoint (#16) * update endpoint * update test * add tests * update test * fix conflict * fix conflict * add test for reportingServerAddress * add test for reportingServerAddress * AGT-498: support report method parameter (#22) * AGT-498: reportMethod * AGT-498: Tests and refactoring * AGT-498: method refactoring * AGT-498: get method refactoring * AGT-498: reportMethod parameter description (#23) * AGT-498: reportMethod * AGT-498: Tests and refactoring * AGT-498: method refactoring * AGT-498: get method refactoring * AGT-498: Documentation * Agt 452 server call counters (#18) * add counters * add unit tests and fixes * counters additions * clear counters when a request is made --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * add siloEnabled feature (#19) * add siloEnabled feature * add siloEnabled feature to analytics adapter * add unit tests for siloEnabled feature * add siloenabled to docs --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * fix unit test issues * AGT-455: Source parameter in requests (#28) * AGT-508: Spd parameter (#29) * AGT-508: Spd parameter * AGT-508: Move appendSpd to utils * AGT-499: Support partnerClientIdType and partnerClientId (#30) * AGT-499: partnerClientId and partnerClientIdType in requests * AGT-499: Clean comment * AGT-499: Refactoring * add groupchanged parameter (#25) * add groupchanged parameter * fix md file issue * add groupChanged example in docs * remove group from example * add unit tests and fix groupChanged issue --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com> * Agt 501 support additional params (#24) * additionalParams feature init * additional params add features * additionalparams fix analytics adapter * add unit tests for additionalParams * fix currentBrowser issue --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com> * fix linter error --------- Co-authored-by: dmytro-po <dmytro.po@intentiq.com> Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com> Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com> Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com> Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * fix unit tests (#32) Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * Agt 547 vr bug for module (#33) * save progress * fix calling server * add "dbsaved" parameter * add tests * AGT-552: Additional query params (#34) * AGT-552: Additional query params * update documentation --------- Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com> * Fix unit test for specific browser * fix spelling --------- Co-authored-by: Eyvaz <62054743+eyvazahmadzada@users.noreply.github.com> Co-authored-by: dmytro-po <dmytro.po@intentiq.com> Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com> Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )