8000 fix: npm install error by astappiev · Pull Request #209 · adityachandelgit/BookLore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: npm install error #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: npm install error #209

wants to merge 1 commit into from
+113 −266

Conversation

astappiev
Copy link
Contributor

Fixes an error

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: typescript-eslint@8.18.0
npm error Found: typescript@5.8.3
npm error node_modules/typescript
npm error   dev typescript@"5.8.3" from the root project
npm error   peer typescript@">=5.5 <5.9" from @angular-devkit/build-angular@19.2.7
npm error   node_modules/@angular-devkit/build-angular
npm error     dev @angular-devkit/build-angular@"19.2.7" from the root project
npm error   14 more (@angular-eslint/builder, ...)
npm error
npm error Could not resolve dependency:
npm error peer typescript@">=4.8.4 <5.8.0" from typescript-eslint@8.18.0
npm error node_modules/typescript-eslint
npm error   dev typescript-eslint@"8.18.0" from the root project
npm error   peer typescript-eslint@"^8.0.0" from angular-eslint@19.3.0
npm error   node_modules/angular-eslint
npm error     dev angular-eslint@"19.3.0" from the root project
npm error
npm error Conflicting peer dependency: typescript@5.7.3
npm error node_modules/typescript
npm error   peer typescript@">=4.8.4 <5.8.0" from typescript-eslint@8.18.0
npm error   node_modules/typescript-eslint
npm error     dev typescript-eslint@"8.18.0" from the root project
npm error     peer typescript-eslint@"^8.0.0" from angular-eslint@19.3.0
npm error     node_modules/angular-eslint
npm error       dev angular-eslint@"19.3.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

It should be safe to use non-fixed minor versions of typescript and typescript-eslint.

Probably other dependencies should also be updated to use ^ or ~ this will make maintenance easier.
And to ensure build works as expected, there is package-lock.json exactly for this reason.

@astappiev
Copy link
Contributor Author

I gave it a test to see if updated version of eslint finds any new errors which were not covered previously and found out that there are 168 problems (168 errors, 0 warnings).

Then, I rolled back to typescript: 5.7, typescript-eslint: 8.18 and found out that there is the same amount of errors.
Maybe then you should consider removing ESLint from dependencies :/

@astappiev astappiev mentioned this pull request May 18, 2025
Merged
@adityachandelgit adityachandelgit force-pushed the develop branch 4 times, most recently from a7f8abb to c34ab84 Compare June 27, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@astappiev
0