8000 fix(eds): json encoding breaks form in eds by nit23uec · Pull Request #1296 · adobe/aem-core-forms-components · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(eds): json encoding breaks form in eds #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix(eds): json encoding breaks form in eds #1296

merged 1 commit into from
Jun 28, 2024

Conversation

nit23uec
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@nit23uec nit23uec requested a review from rismehta June 27, 2024 12:42
@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 96 100 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@codecov Codecov
Copy link
codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.58%. Comparing base (debfe3b) to head (c759f82).

Files Patch % Lines
...ponents/internal/form/FormStructureParserImpl.java 81.25% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #1296      +/-   ##
============================================
+ Coverage     81.52%   81.58%   +0.05%     
  Complexity      847      847              
============================================
  Files            96       96              
  Lines          2252     2259       +7     
  Branches        307      306       -1     
============================================
+ Hits           1836     1843       +7     
- Misses          256      257       +1     
+ Partials        160      159       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 86 96 100 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@rismehta rismehta merged commit 45c3d65 into dev Jun 28, 2024
8 of 9 checks passed
@rismehta rismehta deleted the ue branch June 28, 2024 07:19
@nit23uec nit23uec restored the ue branch June 28, 2024 10:37
@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 90 96 100 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

rismehta pushed a commit that referenced this pull request Jul 11, 2024
@nit23uec @rismehta
fix(eds): json encoding breaks form in eds (#1296)
5c13ff7
dmaurya929 pushed a commit that referenced this pull request Jul 24, 2024
@nit23uec @dmaurya929
fix(eds): json encoding breaks form in eds (#1296)
213ec8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rismehta rismehta rismehta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nit23uec @adobe-bot @rismehta
0