Change collateral of V3 version of file-input #1419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rismehta
reviewed
Sep 25, 2024
| @@ -29,15 +29,13 @@ if (typeof window.FileInputWidget === 'undefined') { | |||
| attachEventHandlers(widget, dragArea, model) { | |||
| super.attachEventHandlers(widget, dragArea, model) | |||
| const customBtn = dragArea?.querySelector(".cmp-adaptiveform-fileinput__widgetlabel") | |||
| customBtn?.addEventListener("click", (event) => { | |||
| event.preventDefault(); | |||
| customBtn?.addEventListener("click", () => { | |||
There was a problem hiding this comment.
Can you add test cases for these changes in v3 spec ?
There was a problem hiding this comment.
It is already written here.
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1419 +/- ##
=========================================
Coverage 82.40% 82.40%
Complexity 919 919
=========================================
Files 103 103
Lines 2358 2358
Branches 317 317
=========================================
Hits 1943 1943
Misses 255 255
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rismehta
pushed a commit
that referenced
this pull request
Oct 16, 2024
Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: