Issue with long description text and introduce data-name attribute in… #1522
Conversation
e22383d to
7800d79
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1522 +/- ##
=========================================
Coverage 82.41% 82.41%
Complexity 968 968
=========================================
Files 107 107
Lines 2491 2491
Branches 342 342
=========================================
Hits 2053 2053
Misses 262 262
Partials 176 176 ☔ View full report in Codecov by Sentry. |
| @@ -29,6 +29,7 @@ | |||
| data-cmp-enabled="${radioButton.enabled ? 'true' : 'false'}" | |||
| data-cmp-required="${radioButton.required ? 'true': 'false'}" | |||
| data-cmp-readonly="${radioButton.readOnly ? 'true' : 'false'}" | |||
| data-name="${radioButton.name}" | |||
There was a problem hiding this comment.
Can we also change id to have the name here, https://github.com/adobe/aem-core-forms-components/blob/master/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/radiobutton/v1/radiobutton/clientlibs/site/js/radiobuttonview.js#L181 (this should be this.id + "_" + this.name
please also add a test case
There was a problem hiding this comment.
@sakshi-arora1 Can you please explain the concern with this change, what was the purpose of adding a constant suffix "_name" to the id attribute ?
| @@ -29,6 +29,7 @@ | |||
| data-cmp-enabled="${radioButton.enabled ? 'true' : 'false'}" | |||
| data-cmp-required="${radioButton.required ? 'true': 'false'}" | |||
| data-cmp-readonly="${radioButton.readOnly ? 'true' : 'false'}" | |||
| data-name="${radioButton.name}" | |||
There was a problem hiding this comment.
@sakshi-arora1 Can you please explain the concern with this change, what was the purpose of adding a constant suffix "_name" to the id attribute ?
b42fecd to
6c586d5
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
… radiobutton
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: