8000 feat. [ACNA-1240] - Developer terms API support. by florind-ens · Pull Request #41 · adobe/aio-cli-lib-console · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat. [ACNA-1240] - Developer terms API support. #41

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2022
Merged

feat. [ACNA-1240] - Developer terms API support. #41

merged 3 commits into from
Mar 14, 2022

Conversation

florind-ens
Copy link
Contributor

Description

Support for Dev Terms API.

Related Issue

adobe/aio-cli-plugin-app#446

Motivation and Context

How Has This Been Tested?

unit tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@florind-ens florind-ens self-assigned this Jan 26, 2022
@codecov
Copy link
codecov bot commented Jan 26, 2022 •
edited
Loading

Codecov Report

Merging #41 (a87e119) into master (443da72) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          431       451   +20     
  Branches        72        74    +2     
=========================================
+ Hits           431       451   +20
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)
lib/pure-helpers.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443da72...a87e119. Read the comment docs.

@florind-ens florind-ens mentioned this pull request Jan 26, 2022
Merged
9 tasks
shazron
shazron requested changes 8000 Mar 7, 2022
View reviewed changes
@florind-ens florind-ens requested a review from shazron March 7, 2022 12:18
@florind-ens florind-ens merged commit 67e5a39 into master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazron shazron shazron approved these changes

@purplecabbage purplecabbage Awaiting requested review from purplecabbage

@Himavanth Himavanth Awaiting requested review from Himavanth

@sandeep-paliwal sandeep-paliwal Awaiting requested review from sandeep-paliwal

Assignees

@florind-ens florind-ens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florind-ens @shazron
0