8000 Turn generator into a lib, aio-cli-lib-console by moritzraho · Pull Request #24 · adobe/aio-cli-lib-console · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Turn generator into a lib, aio-cli-lib-console #24

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 14, 2021
Merged

Turn generator into a lib, aio-cli-lib-console #24

merged 6 commits into from
Sep 14, 2021

Conversation

moritzraho
Copy link
Member
@moritzraho moritzraho commented May 28, 2021 •
edited
Loading

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
codecov bot commented May 28, 2021 •
edited
Loading

Codecov Report

Merging #24 (969a386) into master (7139aa0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         5    -1     
  Lines          506       421   -85     
  Branches        78        65   -13     
=========================================
- Hits           506       421   -85
Impacted Files Coverage Δ
lib/index.js 100.00% <ø> (ø)
lib/pure-helpers.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7139aa0...969a386. Read the comment docs.

@moritzraho moritzraho mentioned this pull request Aug 30, 2021
Closed
@moritzraho moritzraho marked this pull request as ready for review August 30, 2021 08:48
@moritzraho moritzraho changed the title Turn generator into a lib Turn generator into a lib, aio-cli-lib-console Aug 30, 2021
shazron
shazron approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member
@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some merge issues that need resolving, but LGTM

@moritzraho
Copy link
Member Author

thanks Shaz, resolved merge issues, will merge this after tests run

@moritzraho moritzraho merged commit 2e0011e into master Sep 14, 2021
@moritzraho moritzraho deleted the turn-into-lib branch September 14, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazron shazron shazron approved these changes

@Himavanth Himavanth Awaiting requested review from Himavanth

@sandeep-paliwal sandeep-paliwal Awaiting requested review from sandeep-paliwal

@purplecabbage purplecabbage Awaiting requested review from purplecabbage

@meryllblanchet meryllblanchet Awaiting requested review from meryllblanchet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moritzraho @shazron
0