File tree: properly handle clicks on nested files and directories #9353
Conversation
|
Making this change was a bit painful because I was getting unexpected interference from some events that we have bound externally via jQuery. React adds a single event handler high up in the document and processes events on its own. It can be surprising if a jQuery event grabs hold before a seemingly more specific React event. This was also painful because there was a problem (a stray |
Conflicts: src/project/FileTreeView.js
|
I've merged with master and this still fixes 9316, but there is currently a display issue with directory renames. |
|
This is ready for review. There's one minor visual bit (when renaming an open directory, the directory contents shift up by a couple of pixels), but I'd like to start with the review for this so we can get it landed and tweak those couple of pixels either as part of this or soon after depending on timing. |
|
I can't repro the original issue anymore. FBNC @JeffryBooher |
File tree: properly handle clicks on nested files and directories
This is a fix for #9316. In order to make this change, I needed to merge in #9288, so that is in this PR as well.