8000 feat: Enable CSP with nonce + strict-dynamic by andreituicu · Pull Request #360 · adobe/da-live · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Enable CSP with nonce + strict-dynamic #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Enable CSP with nonce + strict-dynamic #360

wants to merge 2 commits into from

Conversation

andreituicu
Copy link
Contributor
@andreituicu andreituicu commented Feb 27, 2025 •
edited
Loading

Description

Tryout a content security policy with nonce + strict-dynamic.

Motivation and Context

This is to help mitigate the risk of XSS.
A more in detail (but not exhaustive) description of what should be protected and what not can be found in adobe/helix-html-pipeline#773 .

Note: currently the nonce generation is Helix 5 only.
As far as I can see, da.live is currently using Helix 4, so it would either need an upgrade of DA to Helix 5, or the backport of the feature to Helix 4 to be deployed (adobe/helix-html-pipeline#811)

How Has This Been Tested?

Manually on https://csp--da-live--adobe.aem.live/ .
I did not observe any CSP violations in the navigation or editor.
Would be interesting if there are any additional automated tests that can be executed.
LE.: looks like the playwright tests from the PR are passing. 🙂

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync AEM Code Sync
Copy link
aem-code-sync bot commented Feb 27, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
aem-code-sync bot commented Feb 27, 2025 •
edited
Loading
Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andreituicu
0