8000 feat: Optionally retain external image URLs identified by specified url prefix by sdmcraft · Pull Request #725 · adobe/helix-html2md · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Optionally retain external image URLs identified by specified url prefix #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 19, 2025
Merged

feat: Optionally retain external image URLs identified by specified url prefix #725

merged 20 commits into from
May 19, 2025

Conversation

sdmcraft
Copy link
Collaborator

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

#724

@sdmcraft sdmcraft requested review from tripodsan, rofe and actinium15 May 12, 2025 14:14
@sdmcraft sdmcraft mentioned this pull request May 12, 2025
Closed
@github-actions GitHub Actions
Copy link

This PR will trigger a minor release when merged.

tripodsan
tripodsan reviewed May 13, 2025
View reviewed changes
tripodsan
tripodsan reviewed May 13, 2025
View reviewed changes
@codecov Codecov
Copy link
codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8e8bb70) to head (881b4b5).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #725   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          896       920   +24     
  Branches         1         1           
=========================================
+ Hits           896       920   +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tripodsan
tripodsan reviewed May 14, 2025
View reviewed changes
tripodsan
tripodsan reviewed May 14, 2025
View reviewed changes
@sdmcraft sdmcraft marked this pull request as ready for review May 15, 2025 16:42
@sdmcraft
Copy link
Collaborator Author

@tripodsan , thanks for reviewing. I believe I have addressed all the review feedback. Also tested it with the deployed ci build. Marking this ready to merge. Could you please take a look and let me know if it good to merge?

@sdmcraft sdmcraft changed the title feat(DMwOAPI): Optionally retain DMwOAPI image URLs feat: Optionally retain external image URLs identified by specified url prefix May 15, 2025
tripodsan
tripodsan requested changes May 16, 2025
View reviewed changes
Copy link
Contributor
@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to track the external images

tripodsan
tripodsan reviewed May 19, 2025
View reviewed changes
tripodsan
tripodsan reviewed May 19, 2025
View reviewed changes
tripodsan
tripodsan reviewed May 19, 2025
View reviewed changes
@sdmcraft sdmcraft merged commit bdcebb5 into main May 19, 2025
8 checks passed
@sdmcraft sdmcraft deleted the i-274 branch May 19, 2025 11:02
github-actions bot pushed a commit that referenced this pull request May 19, 2025
@semantic-release-bot
chore(release): 2.17.0 [skip ci]
d45b096 
# [2.17.0](https://github.com/adobe/[secure]-html2md/compare/v2.16.10...v2.17.0) (2025-05-19)

### Features

* **external images:** augment image processing to optionally skip uploads for external images  ([#725](https://github.com/adobe/[secure]-html2md/issues/725)) ([bdcebb5](https://github.com/adobe/[secure]-html2md/commit/bdcebb5b14d11be2fae79d1eb269368a020af45f))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tripodsan tripodsan tripodsan approved these changes

@rofe rofe Awaiting requested review from rofe

@actinium15 actinium15 Awaiting requested review from actinium15

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdmcraft @tripodsan
0