10000 57 allow asserts to use matchers by baubakg · Pull Request #171 · adobe/log-parser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

57 allow asserts to use matchers #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 29, 2024
Merged

57 allow asserts to use matchers #171

merged 5 commits into from
Aug 29, 2024

Conversation

baubakg
Copy link
Member
@baubakg baubakg commented Aug 29, 2024

Description

We now want the log - parser to Hamcrest matchers for the validation

Related Issue

Fixes issue #57

Motivation and Context

The existing assertions were a bit too simple, and instead we chose to use Hamcrest matchers.

How Has This Been Tested?

unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] I have signed the Adobe Open Source CLA.
  • [ x] My code follows the code style of this project.
  • [ x] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@baubakg baubakg linked an issue Aug 29, 2024 that may be closed by this pull request
Allow asserts to use Matchers #57
Closed
@codecov Codecov
Copy link
codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.09%. Comparing base (24dc14a) to head (b9a7b0b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #171      +/-   ##
============================================
+ Coverage     97.04%   97.09%   +0.04%     
- Complexity      358      365       +7     
============================================
  Files            22       22              
  Lines           915      930      +15     
  Branches        123      124       +1     
============================================
+ Hits            888      903      +15     
  Misses           16       16              
  Partials         11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
38 New issues
0 Accepted issues

Measures
0 Security Hotspots
99.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@baubakg baubakg merged commit 0202847 into main Aug 29, 2024
10 checks passed
@baubakg baubakg deleted the 57-allow-asserts-to-use-matchers branch August 29, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
< 4403 /option>
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow asserts to use Matchers
1 participant
@baubakg
0