8000 fix(popover): implement missing border width custom property by marissahuysentruyt · Pull Request #3995 · adobe/spectrum-css · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(popover): implement missing border width custom property #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: spectrum-two
Choose a base branch
from
Draft

fix(popover): implement missing border width custom property #3995

wants to merge 1 commit into from

Conversation

marissahuysentruyt
Copy link
Collaborator
  • defines the missing --spectrum-popover-border-width custom property
  • create changeset
  • update metadata

Description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@marissahuysentruyt
fix(popover): implement missing border width custom property
7634baa 
- defines the missing `--spectrum-popover-border-width` custom property
- create changeset
- update metadata
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 25, 2025

🦋 Changeset detected

Latest commit: 7634baa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@spectrum-css/popover Patch
@spectrum-css/bundle Patch
@spectrum-css/preview Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marissahuysentruyt marissahuysentruyt self-assigned this Jun 25, 2025
@marissahuysentruyt marissahuysentruyt added bug Results from a bug in the CSS implementation size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. S2 Spectrum 2 labels Jun 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

File metrics

Summary

Total size: 1.42 MB*

Package Size Minified Gzipped
popover 16.42 KB 15.82 KB 2.03 KB

popover

Filename Head Minified Gzipped Compared to base
index.css 16.42 KB 15.82 KB 2.03 KB 🔴 ⬆ 0.07 KB
metadata.json 8.15 KB - - 🔴 ⬆ 0.04 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions GitHub Actions
Copy link
Contributor

📚 Branch preview

PR #3995 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-3995/index.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marissahuysentruyt marissahuysentruyt

Labels
bug Results from a bug in the CSS implementation S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marissahuysentruyt
0