8000 MWPW-172853: Enable maslibs from web-components folder by Axelcureno · Pull Request #290 · adobecom/mas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-172853: Enable maslibs from web-components folder #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Jul 11, 2025
Merged

MWPW-172853: Enable maslibs from web-components folder #290

merged 54 commits into from
Jul 11, 2025

Conversation

Axelcureno
Copy link
Member
@Axelcureno Axelcureno commented Jun 10, 2025 •
edited
Loading

Enables maslibs with 'npm run libs' from /web-components folder.
Note: This change has zero impact on current mas.js consumption.

Resolves https://jira.corp.adobe.com/browse/MWPW-172853

QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Test URLs:

@aem-code-sync AEM Code Sync
Copy link
aem-code-sync bot commented Jun 10, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
aem-code-sync bot commented Jun 10, 2025 •
edited
Loading
Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Axelcureno Axelcureno self-assigned this Jun 10, 2025
@Axelcureno Axelcureno mentioned this pull request Jun 10, 2025
Open
mirafedas
mirafedas previously approved these changes Jun 11, 2025
View reviewed changes
npeltier
npeltier previously approved these changes Jun 13, 2025
View reviewed changes
3ch023
3ch023 reviewed Jun 23, 2025
View reviewed changes 
…oper tag closure in benchmarks.html, step-by-step.html, and various test files.
3ch023
3ch023 previously approved these changes Jul 9, 2025
View reviewed changes
@3ch023 3ch023 added the trivial label Jul 11, 2025
@3ch023 3ch023 merged commit d9033df into main Jul 11, 2025
7 checks passed
@3ch023 3ch023 deleted the MWPW-172853 branch July 11, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3ch023 3ch023 3ch023 approved these changes

@npeltier npeltier npeltier left review comments

@mirafedas mirafedas mirafedas left review comments

@afmicka afmicka Awaiting requested review from afmicka

Assignees

@Axelcureno Axelcureno

Labels
trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Axelcureno @npeltier @3ch023 @mirafedas
0