8000 MWPW-170203: Mini Compare Card Bullet List style adjustments by mirafedas · Pull Request #4157 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-170203: Mini Compare Card Bullet List style adjustments #4157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2025
Merged

MWPW-170203: Mini Compare Card Bullet List style adjustments #4157

merged 3 commits into from
Jun 11, 2025

Conversation

mirafedas
Copy link
Contributor
@mirafedas mirafedas commented May 15, 2025 •
edited by github-actions bot
Loading

Changes for mini-compare-chart variant of a merch card with .bullet-list (mobile only):

  1. Set the price font size to 32px and font weight to 800.
  2. Updated font size to 16px for: "Starting at" (labeled as eyebrows in Jira), product name, "See what's included" dropdown header, and button CTAs.
  3. Set font size to 14px for the badge, description, legal copy, promo copy, and secure transaction text.
  4. Added a new light gray color for the card border.
  5. Removed the yellow border from cards with a badge.
  6. Left-aligned the CTAs and increased their height to 40px.
  7. Updated the body text and "Most popular" tag font size to 16px.
  8. Changed the card heading font size ("Photoshop") to 18px.
  9. Added plus and minus buttons.
  10. Updated the checklist font size to 16px and changed the background color to #F8F8F8.
  11. Adjusted paddings to match the Figma spec.
    ... and many other small changes

Resolves: MWPW-170203

Test URLs:

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented May 15, 2025 •
edited
Loading
Page Scores Audits Google
📱 /drafts/mirafedas/mini-compare-charts/mini-compare-bullet-list?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/mirafedas/mini-compare-charts/mini-compare-bullet-list?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@mirafedas mirafedas requested a review from a team as a code owner May 26, 2025 10:43
@mirafedas mirafedas force-pushed the mwpw-170203-mini-compare-mobile branch from 77cabab to c0a5d59 Compare June 6, 2025 09:47
@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage labels Jun 7, 2025
@mirafedas mirafedas force-pushed the mwpw-170203-mini-compare-mobile branch from ad8d861 to 7d0b7a6 Compare June 9, 2025 13:10
@mirafedas mirafedas removed the verified PR has been E2E tested by a reviewer label Jun 9, 2025
@mirafedas
Copy link
Contributor Author

@Roycethan I had to add changes, could you please verify again?

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage labels Jun 9, 2025
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jun 9, 2025

Error merging 4157: MWPW-170203: Mini Compare Card Bullet List style adjustments Pull Request is not mergeable

@overmyheadandbody overmyheadandbody added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Jun 10, 2025
@milo-pr-merge milo-pr-merge bot merged commit 21cee16 into adobecom:stage Jun 11, 2025
17 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3ch023 3ch023 3ch023 approved these changes

@bozojovicic bozojovicic bozojovicic approved these changes

@yesil yesil Awaiting requested review from yesil

@npeltier npeltier Awaiting requested review from npeltier

@Axelcureno Axelcureno Awaiting requested review from Axelcureno

@seanchoi-dev seanchoi-dev Awaiting requested review from seanchoi-dev

@markovicpredrag1209 markovicpredrag1209 Awaiting requested review from markovicpredrag1209

@st-angelo-adobe st-angelo-adobe Awaiting requested review from st-angelo-adobe

Assignees
No one assigned
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mirafedas @3ch023 @bozojovicic @overmyheadandbody @Roycethan
0