8000 MWPW-173732 [MMM][MEP] Add contextually relevant button in Target Metadata Lookup Report by ivanvatadobe · Pull Request #4192 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-173732 [MMM][MEP] Add contextually relevant button in Target Metadata Lookup Report #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 20, 2025
Merged

MWPW-173732 [MMM][MEP] Add contextually relevant button in Target Metadata Lookup Report #4192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fcf6d86
first commit
ivanvatadobe May 19, 2025
c93d31f
add button selector for .instructions text block
ivanvatadobe May 19, 2025
52da843
Refactor metadata URLs in createMetadataLookup function for improved …
vgoodric May 19, 2025
e4c216b
Add TARGET_METADATA_OPTIONS for improved metadata handling in createM…
vgoodric May 20, 2025
a296998
Merge branch 'stage' into mmm-metadata-addbutton
vgoodric May 20, 2025
50830eb
Update label text for last seen manifests dropdown for mmm and mep-ta…
ivanvatadobe May 20, 2025
de7ec76
Merge branch 'limit-manifest-by-filter' into mmm-metadata-addbutton
vgoodric May 20, 2025
b47c78a
Merge branch 'limit-manifest-by-filter' into mmm-metadata-addbutton
vgoodric May 20, 2025
0969247
Refactor metadata lookup to use updated search function for selectedRepo
vgoodric May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 31 additions & 11 deletions libs/blocks/mmm/mmm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,28 @@ const METADATA_URLS_CATEGORIES = {
postLCP: { display: 'PostLCP', key: 'postLCP' },
};

const TARGET_METADATA_OPTIONS = {
cc: {
name: 'CC',
metadata: 'https://main--cc--adobecom.aem.live/metadata-optimization.json',
source: 'https://adobe.sharepoint.com/:x:/r/sites/adobecom/_layouts/15/Doc.aspx?sourcedoc=%7B818b8ad2-72db-4726-85a6-5238d6715069%7D&action=edit&activeCell=%27helix-default%27!A16&wdinitialsession=11b36a4d-a08b-0def-1294-1fcf497cfc1a&wdrldsc=4&wdrldc=1&wdrldr=AccessTokenExpiredWarningUnauthenticated%2CRefreshin',
},
dc: {
name: 'DC',
metadata: 'https://main--dc--adobecom.aem.live/metadata-optimization.json',
source: 'https://adobe.sharepoint.com/:x:/r/sites/adobecom/_layouts/15/Doc.aspx?sourcedoc=%7B8F5A8CD0-7979-41CE-894A-CC465B293C1A%7D&file=metadata-optimization.xlsx&action=default&mobileredirect=true&wdsle=0',
},
express: {
name: 'Express',
metadata: 'https://main--express-milo--adobecom.aem.live/metadata-optimization.json',
source: 'https://adobe.sharepoint.com/:x:/r/sites/adobecom/_layouts/15/Doc.aspx?sourcedoc=%7BEC96D2B9-9F25-48AF-B88A-A6926A340D3A%7D&file=metadata-optimization.xlsx&action=default&mobileredirect=true',
},
bacom: {
name: 'BACOM',
metadata: 'https://main--bacom--adobecom.aem.live/metadata-optimization.json',
source: 'https://adobe.sharepoint.com/:x:/r/sites/adobecom/_layouts/15/Doc.aspx?sourcedoc=%7BEE70634D-C16E-45E7-B16E-718C5022413E%7D&file=metadata-optimization.xlsx&action=default&mobileredirect=true&wdsle=0',
},
};
let isReport = false;
let mmmPageVer = GRID_FORMAT.base;
let isMetadataLookup = false;
Expand Down Expand Up @@ -312,7 +334,7 @@ function createLastSeenManifestAndDomainDD() {
'div',
{ id: 'mmm-dropdown-lastSeen', class: 'mmm-form-container' },
`<div>
<label for="mmm-lastSeenManifest">Target manifests ${isReport ? 'not ' : ''}seen in the last:</label>
<label for="mmm-lastSeenManifest">${isReport ? 'Target manifests not' : 'Manifests'} seen in the last:</label>
<select id="mmm-lastSeenManifest" type="text" name="mmm-lastSeenManifest" class="text-field-input">

</select>
Expand Down Expand Up @@ -705,26 +727,20 @@ function handleMetadataFilterInput(event) {
}

function createMetadataLookup(el) {
const openMetadataSheetBtn = document.querySelector('.text.instructions .cta-container a');
const dropdown = {
id: 'mmm-metadata-lookup-repo-cc',
label: 'Choose Repo',
selected: SEARCH().selectedRepo,
options: {
cc: 'CC',
dc: 'DC',
express: 'Express',
bacom: 'BACOM',
},

};

const search = createTag('div', { class: 'mmm-metadata-lookup' }, `
<div class="mmm-form-container">
<div>
<label for="${dropdown.id}">${dropdown.label}:</label>
<select id="${dropdown.id}" class="text-field-input">
${Object.keys(dropdown.options).map((key) => `
<option value="${key}" ${dropdown.selected === key ? 'selected' : ''}>${dropdown.options[key]}</option>
${Object.keys(TARGET_METADATA_OPTIONS).map((key) => `
<option value="${key}" ${dropdown.selected === key ? 'selected' : ''}>${TARGET_METADATA_OPTIONS[key].name}</option>
`).join('')}
</select>
</div>
Expand All @@ -737,6 +753,10 @@ function createMetadataLookup(el) {
<button id="mmm-copy-metadata-report" class="mmm-metadata-lookup__button primary mmm-hide" style="align-self: center">Copy Report</button>
`);
el.append(search);
// Edit REP button label and URL
const { name, source } = TARGET_METADATA_OPTIONS[dropdown.selected];
openMetadataSheetBtn.innerHTML = `Open ${name} Spreadsheet`;
openMetadataSheetBtn.href = source;

// Handle REPO change
// eslint-disable-next-line no-use-before-define
Expand Down Expand Up @@ -785,7 +805,7 @@ async function createView(el, search) {
switch (true) {
case isReport: url = API_URLS.report; break;
case isMetadataLookup: {
url = API_URLS.metadata[SEARCH().selectedRepo];
url = TARGET_METADATA_OPTIONS[SEARCH().selectedRepo].metadata;
method = 'GET';
body = null;
break;
Expand Down
6 changes: 0 additions & 6 deletions libs/features/personalization/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ export const API_URLS = {
pageDetails: `${API_DOMAIN}/get-page`,
save: `${API_DOMAIN}/save-mep-call`,
report: `${API_DOMAIN}/get-report`,
metadata: {
cc: 'https://main--cc--adobecom.aem.live/metadata-optimization.json',
dc: 'https://main--dc--adobecom.aem.live/metadata-optimization.json',
express: 'https://main--express-milo--adobecom.aem.live/metadata-optimization.json',
bacom: 'https://main--bacom--adobecom.aem.live/metadata-optimization.json',
},
};

function updatePreviewButton(popup, pageId) {
Expand Down
0