[Release] Stage to Main #4227
[Release] Stage to Main #4227
Conversation
* wip * wip * wip * wip * unit tests + css * demo page * updated deps * tooltip * tooltip * Update popover.js * Update fries.html * Update fries.html * cta toggle text * wip * updated deps * wip * wip * updated deps * unit tests * ut fixes * updated deps * ut fix * Update merch-offer-select.test.js * NALA fix * conflicts resolved * fixes * text decoration * yellow color dark theme * Update fries.html * remove console log * font size addon confirmation * Update merch-card.fries.test.html.js * dark theme body color * dark theme * icon size * responsiveness * styles * body-s color * Update styles.css * Update fries.html * Updated CSS * color * updated deps * resolved conflicts * css * increased max count for fries card
* ribbon in-line * ribbon in-line * ribbon in-line * review comment --------- Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local>
* MWPW-169410: Add download icon to sidekick * MWPW-169410: Remove title and description to avoid announcment duplication * MWPW-169410: Change title to Download icon
|
Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot |
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/merch-card.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/merch-icon.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/dist/mas.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/src/global.css.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/src/hydrate.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/src/mas.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/src/merch-badge.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/src/merch-card.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/src/merch-icon.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
| document.querySelectorAll('code.demo').forEach(el => { | ||
| const targetContainer = document.createElement('div'); | ||
| targetContainer.classList.toggle('light', el.classList.contains('light')); | ||
| targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium documentation
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 2 months ago
To fix the issue, we need to ensure that the content of el.textContent is treated as plain text and not reinterpreted as HTML. This can be achieved by creating a text node for the content and appending it to the DOM instead of using innerHTML. This approach ensures that any special characters in the text are properly escaped and cannot be executed as HTML or JavaScript.
The fix involves:
- Replacing the use of
innerHTMLwith DOM manipulation methods that handle text safely. - Creating a text node for
el.textContentand appending it to the appropriate container.
The changes will be made in the <script> block starting at line 126.
| @@ -129,3 +129,9 @@ | ||
| targetContainer.classList.toggle('light', el.classList.contains('light')); | ||
| targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`; | ||
| const demoHeader = document.createElement('h4'); | ||
| demoHeader.textContent = 'Demo: '; | ||
| const demoContainer = document.createElement('div'); | ||
| demoContainer.className = 'demo-container'; | ||
| demoContainer.textContent = el.textContent; | ||
| targetContainer.appendChild(demoHeader); | ||
| targetContainer.appendChild(demoContainer); | ||
| el.parentElement.after(targetContainer); |
Updating codeowners for region nav and navigation folder
* Wrapping the test urls in a collapsed section * Update title
* Update notification z indexes with values * Update notification.css
* [MWPW-173016] - block korea free trial links/buttons * [MWPW-173016] - korea text filter added * [MWPW-173016] - update if * [MWPW-173016] - code optimization * [MWPW-173016] - improve import * [MWPW-173016] - modal check, string check added * [MWPW-173016] - strings added * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - update logic * [MWPW-173470] - remove whitespace * [MWPW-173470] - optimize * [MWPW-173470] - remove variable * [MWPW-173016] - optimize code * [MWPW-173016] - group logic * [MWPW-173016] - merch solution added * [MWPW-173016] - merch ref comment added * [MWPW-173470] - null safe * [MWPW-173470] - code optimization * [MWPW-173470] - nav korea restrict coverage * [MWPW-173470] - fix eslint console error --------- Co-authored-by: Dusan Kosanovic <dusan.kosanovic@hitthecode.com>
There was a problem hiding this comment.
Unexpected console statement.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo:
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale