8000 Mweb tabs, editorial cards, icon block by overmyheadandbody · Pull Request #4259 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mweb tabs, editorial cards, icon block #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 39 additions & 11 deletions libs/mep/ace1052/editorial-card/editorial-card.css
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@
cursor: pointer;
}

.editorial-card.click.hover-scale {
.editorial-card.click.hover-scale {
transition: all .2s ease-in-out;
}

.editorial-card.click.hover-scale:hover {
.editorial-card.click.hover-scale:hover {
transform: scale(var(--card-scale-default));
}

.editorial-card:not(.no-bg).click.hover-scale:hover {
.editorial-card:not(.no-bg).click.hover-scale:hover {
box-shadow: 0 3px 6px 0 rgba(0 0 0 / 16%);
}

Expand Down Expand Up @@ -149,7 +149,7 @@
line-height: 0;
}

.editorial-card.no-foreground {
.editorial-card.no-foreground {
border: none;
}

Expand All @@ -160,7 +160,7 @@
.editorial-card.footer-align-left .card-footer > div { text-align: start; }
.editorial-card.footer-align-center .card-footer > div { text-align: center; }

.editorial-card.no-bg.no-border .foreground > div {
.editorial-card.no-bg.no-border .foreground > div {
row-gap: var(--spacing-xs);
}

Expand All @@ -170,7 +170,7 @@
height: 100%;
}

.editorial-card .background .milo-video,
.editorial-card .background .milo-video,
.editorial-card .background .milo-iframe {
height: 100%;
padding-bottom: 0;
Expand All @@ -194,7 +194,7 @@
line-height: initial;
}

.editorial-card .action-area,
.editorial-card .action-area,
.editorial-card .card-footer > .action-area {
display: flex;
align-items: center;
Expand All @@ -204,7 +204,7 @@
flex-direction: row;
}

.editorial-card .action-area .con-button {
.editorial-card .action-area .con-button {
white-space: nowrap;
}

Expand Down Expand Up @@ -279,9 +279,9 @@
}

/* Align */
.editorial-card.center {
text-align: center;
justify-items: center;
.editorial-card.center {
text-align: center;
justify-items: center;
}

.editorial-card.footer-align-left .action-area { justify-content: start; }
Expand Down Expand Up @@ -366,3 +366,31 @@
align-items: center;
}
}

/* Mweb specific */
@media screen and (max-width: 599px) {
/* General */
:root {
--type-heading-all-weight: 800;
}

[class^="heading-"] {
font-weight: var(--type-heading-all-weight);
}

[class^="detail-"] {
text-transform: unset;
}

[class^="detail-"] strong {
font-weight: 500;
}

/* Block specific */
/* Ideally this would be addressed on L22 */
.light .editorial-card,
.editorial-card.light {
color: var(--text-color);
border-color: var(--color-gray-300);
}
}
7 changes: 2 additions & 5 deletions libs/mep/ace1052/hero-marquee/hero-marquee.css
Original file line number Diff line number Diff line change
Expand Up @@ -334,10 +334,6 @@ html[dir="rtl"] .hero-marquee li.icon-item span.icon {

.hero-marquee.media-hidden-mobile .foreground .asset,
.hero-marquee.media-hidden-mobile .foreground-media { display: none; }

.hero-marquee .con-block.row-text:has(.action-area) + .con-block.row-text .row-wrapper {
text-align: center;
}
}

/* Tablet ONLY */
Expand Down Expand Up @@ -536,7 +532,8 @@ html[dir="rtl"] .hero-marquee li.icon-item span.icon {
}

/* Block specific */
.hero-marquee .action-area a:not(.con-button) {
.hero-marquee .action-area a:not(.con-button),
.hero-marquee .con-block.row-text:has(.action-area) + .con-block.row-text .row-wrapper {
align-self: center;
font-size: 17px;
}
Expand Down
16 changes: 16 additions & 0 deletions libs/mep/ace1052/icon-block/icon-block.css
Original file line number Diff line number Diff line change
Expand Up @@ -535,10 +535,26 @@
height: var(--icon-size-s);
}

.icon-block.full-width .foreground .icon-area {
margin-bottom: var(--spacing-xs);
}

.section:has(.icon-block + .action-scroller) {
width: var(--grid-container-width);
margin: auto;
background: #EEE;
border-radius: var(--l-rounded-corners);
}

.section:has(.icon-block + .action-scroller) .action-scroller .scroller {
--mask-width: var(--grid-margins-width);

padding-inline: var(--grid-margins-width);
gap: var(--spacing-xs);
}

.section:has(.icon-block + .action-scroller) .action-item .main-image {
max-width: 60px;
margin-inline: auto;
}
}
2 changes: 1 addition & 1 deletion libs/mep/ace1052/icon-block/icon-block.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const iconBlocks = {
[variants[3]]: ['s', 's'],
},
medium: {
[variants[0]]: ['l', 's'], /* Mweb specific */
[variants[0]]: ['l', 's'], /* Mweb specific, s was m */
[variants[1]]: ['m', 'm'],
[variants[2]]: ['s', 's'],
[variants[3]]: ['s', 's'],
Expand Down
Loading
0