[Loc][MWPW-173706] Fix selection of transcreation locale #4253
+123
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update stage build
…ecom#3975) fix: bacom blog mapping and added ref in session storage
* update stage build * update reference file
…en (adobecom#4152) * add transcreation locales to loc create * fix: remove transcreation constant * fix: lint issues
…m#4167) * added date time picker for loc * fix: lint errors
* stage deployment * test change to trigger lint * revert test change
|
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
nkthakur48
requested changes
Jun 10, 2025
|
Heya, since this PR has been open since a while - could you leave some feedback on https://github.com/orgs/adobecom/discussions/4407 why/what is blocking this from proceeding? |
nkthakur48
approved these changes
Jun 16, 2025
|
@maagrawal16 Could you please resolve the conflicts? |
maagrawal16
added a commit
to maagrawal16/milo
that referenced
this pull request
Jun 30, 2025
* [DA] Milostudio dev to stage (adobecom#3972) update stage build * [DA] Fixed da bacom blog mapping & added ref in session storage (adobecom#3975) fix: bacom blog mapping and added ref in session storage * MWPW-171589 Support DA Apps on gwp-playground * [DA] Stage deployment (7 May) (adobecom#4090) * update stage build * update reference file * [Loc][MWPW-173377] Add Transcreation Locales in Select Languages Screen (adobecom#4152) * add transcreation locales to loc create * fix: remove transcreation constant * fix: lint issues * [Loc][MWPW-173379] Add Date Time Picker in Enter URLs Screen (adobecom#4167) * added date time picker for loc * fix: lint errors * [DA] Stage deployment (20 May) (adobecom#4193) * stage deployment * test change to trigger lint * revert test change * fix: selection of transcreation locale * fix: lint errors * created langcode locale mapping * fix lint errors * fix: region selection for transcreation locales * fix: edit workflow for transcreation locales * minor fixes * fix: lint errors * added review comment fixes * fix lint errors * merge vendor.js * resolve conflicts --------- Co-authored-by: Nishant Kumar Thakur <nishant.thakur.ece@gmail.com>
nkthakur48
added a commit
that referenced
this pull request
Jun 30, 2025
* [Loc][MWPW-173706] Fix selection of transcreation locale (#4253) * [DA] Milostudio dev to stage (#3972) update stage build * [DA] Fixed da bacom blog mapping & added ref in session storage (#3975) fix: bacom blog mapping and added ref in session storag 8000 e * MWPW-171589 Support DA Apps on gwp-playground * [DA] Stage deployment (7 May) (#4090) * update stage build * update reference file * [Loc][MWPW-173377] Add Transcreation Locales in Select Languages Screen (#4152) * add transcreation locales to loc create * fix: remove transcreation constant * fix: lint issues * [Loc][MWPW-173379] Add Date Time Picker in Enter URLs Screen (#4167) * added date time picker for loc * fix: lint errors * [DA] Stage deployment (20 May) (#4193) * stage deployment * test change to trigger lint * revert test change * fix: selection of transcreation locale * fix: lint errors * created langcode locale mapping * fix lint errors * fix: region selection for transcreation locales * fix: edit workflow for transcreation locales * minor fixes * fix: lint errors * added review comment fixes * fix lint errors * merge vendor.js * resolve conflicts --------- Co-authored-by: Nishant Kumar Thakur <nishant.thakur.ece@gmail.com> * update build and cherry pick loc changes --------- Co-authored-by: Nishant Kumar Thakur <nishant.thakur.ece@gmail.com>
maagrawal16
added a commit
to maagrawal16/milo
that referenced
this pull request
Jul 7, 2025
* [DA] Milostudio dev to stage (adobecom#3972) update stage build * [DA] Fixed da bacom blog mapping & added ref in session storage (adobecom#3975) fix: bacom blog mapping and added ref in session storage * MWPW-171589 Support DA Apps on gwp-playground * [DA] Stage deployment (7 May) (adobecom#4090) * update stage build * update reference file * [Loc][MWPW-173377] Add Transcreation Locales in Select Languages Screen (adobecom#4152) * add transcreation locales to loc create * fix: remove transcreation constant * fix: lint issues * [Loc][MWPW-173379] Add Date Time Picker in Enter URLs Screen (adobecom#4167) * added date time picker for loc * fix: lint errors * [DA] Stage deployment (20 May) (adobecom#4193) * stage deployment * test change to trigger lint * revert test change * fix: selection of transcreation locale * fix: lint errors * created langcode locale mapping * fix lint errors * fix: region selection for transcreation locales * fix: edit workflow for transcreation locales * minor fixes * fix: lint errors * added review comment fixes * fix lint errors * merge vendor.js * resolve conflicts --------- Co-authored-by: Nishant Kumar Thakur <nishant.thakur.ece@gmail.com>
aishwaryamathuria
pushed a commit
that referenced
this pull request
Jul 7, 2025
* [Loc][MWPW-173706] Fix selection of transcreation locale (#4253) * [DA] Milostudio dev to stage (#3972) update stage build * [DA] Fixed da bacom blog mapping & added ref in session storage (#3975) fix: bacom blog mapping and added ref in session storage * MWPW-171589 Support DA Apps on gwp-playground * [DA] Stage deployment (7 May) (#4090) * update stage build * update reference file * [Loc][MWPW-173377] Add Transcreation Locales in Select Languages Screen (#4152) * add transcreation locales to loc create * fix: remove transcreation constant * fix: lint issues * [Loc][MWPW-173379] Add Date Time Picker in Enter URLs Screen (#4167) * added date time picker for loc * fix: lint errors * [DA] Stage deployment (20 May) (#4193) * stage deployment * test change to trigger lint * revert test change * fix: selection of transcreation locale * fix: lint errors * created langcode locale mapping * fix lint errors * fix: region selection for transcreation locales * fix: edit workflow for transcreation locales * minor fixes * fix: lint errors * added review comment fixes * fix lint errors * merge vendor.js * resolve conflicts --------- Co-authored-by: Nishant Kumar Thakur <nishant.thakur.ece@gmail.com> * update build and added loc changes for prod --------- Co-authored-by: Nishant Kumar Thakur <nishant.thakur.ece@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-173706
Test URLs: