8000 MWPW-174157: [MEP][MILO] Add alloy event handling to links and ability in MEP to more easily add that data to a link by denlight · Pull Request #4268 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-174157: [MEP][MILO] Add alloy event handling to links and ability in MEP to more easily add that data to a link #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 23, 2025
Merged

MWPW-174157: [MEP][MILO] Add alloy event handling to links and ability in MEP to more easily add that data to a link #4268

merged 8 commits into from
Jun 23, 2025

Conversation

denlight
Copy link
Contributor
@denlight denlight commented May 30, 2025 •
edited by github-actions bot
Loading
  • Added ability to append alloy event string to the end of the href of a link via updateAttribute action
  • example selector: marquee primary-cta href_#
  • example value: #_alloy:profile.business_segment:my_sample_value

Resolves: MWPW-174157

Test URLs:

QA link - https://main--cc--adobecom.aem.page/drafts/mepdev/fragments/2025/q2/addalloy/marquee?milolibs=add-alloy

Sharepoint link: https://adobe.sharepoint.com/:f:/r/sites/adobecom/CC/www/drafts/mepdev/fragments/2025/q2/addalloy?csf=1&web=1&e=zi7mdp

Since clicking on an alloy link(primary cta of the marquee) will take you out of the page, in order to test the feature open dev console, find utils.js and set a break point on line 926 before clicking the link

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented May 30, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented May 30, 2025 •
edited
Loading
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@denlight denlight changed the title [MWPW-174157]: added alloy event handling for MEP and Manifest [MEP][MILO] MWPW-174157: added alloy event handling for MEP and Manifest May 30, 2025
@vgoodric vgoodric changed the title [MEP][MILO] MWPW-174157: added alloy event handling for MEP and Manifest MWPW-174157: [MEP][MILO] Add alloy event handling to links and ability in MEP to more easily add that data to a link May 30, 2025
@vgoodric vgoodric added the do not merge PR should not be merged yet label Jun 1, 2025
vgoodric
vgoodric reviewed Jun 4, 2025
View reviewed changes
@denlight denlight requested review from vgoodric and bbythewa June 5, 2025 20:02
@vgoodric vgoodric removed the do not merge PR should not be merged yet label Jun 6, 2025
@mokimo
Copy link
Contributor
mokimo commented Jun 16, 2025

Heya, since this PR has been open since a while - could you leave some feedback on https://github.com/orgs/adobecom/discussions/ 8000 4407 why/what is blocking this from proceeding?

@vgoodric vgoodric added the verified PR has been E2E tested by a reviewer label Jun 19, 2025
@milo-pr-merge milo-pr-merge bot merged commit abc03c9 into stage Jun 23, 2025
21 checks passed
@milo-pr-merge milo-pr-merge bot deleted the add-alloy branch June 23, 2025 09:21
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgoodric vgoodric vgoodric approved these changes

@ivanvatadobe ivanvatadobe ivanvatadobe approved these changes

@bbythewa bbythewa Awaiting requested review from bbythewa

Assignees
No one assigned
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denlight @mokimo @vgoodric @ivanvatadobe
0