[Release] Stage to Main #4278
[Release] Stage to Main #4278
Conversation
…ssue (#4177) * fixed visual list is not marked up as list a11y issue * fixed eslint * Fixed footer alignment * refactored the code * fixed review comments
* MWPW-169219: Add tooltip to aside promo popup * MWPW-169219: Move tooltip icon to the right on mobile * MWPW-169219: Move tooltip icon on mobile to the left * MWPW-169219: Set tooltip font size to heading font size and align it * MWPW-169219: Add support for rtl * MWPW-169219: Pr update * MWPW-169219: PR feedback * MWPW-169219: Set tooltip height to 16px
… has not loaded (Desktop & Mobile) (#4213) * Parallelize the network calls required before the gnav becomes visible * corrected the logic for loading base styles for non-milo contexts * load aside.js in parallel if necessary * made the logic inside getGnavSource a little more fault tolerant * Fixed an issue with loading the dark mode gnav (standalone) * changed the gnav tests to reload the global-navigation.js module anew on each test to work correctly with the performance optimizations * Fixed a test for localnav inside bootstrapper.test.js * ignore eslint error on a test * added error handling to the style loading logic in gnav * changed error handling for loading gnav styles from throwing an error to rejecting a promise * removed some redundant code * changed e.message to e * implemented the loading state for desktop viewports * Change animation name as it was the same as one that the unav uses * implemented the loading state for mobile * Removed pointer events from the loading state; made the loading state closer to the specs * Finishing touches * Don't have a loading state for the legacy mobile gnav * add the loading state only on async Dropdowns; decorateLocalnav should be inside decorateMenu.then(...) * put the call to `decorateLocalNavItems` inside `finally` to make sure it runs * lint fixes * Sometimes mobileNavCleanup can be null * Removed an extraneous line * Cleaning up the merge conflict resolution * Make sure `transformTemplateToMobile` always returns a function * Revert "Revert "MWPW-167709 [GNAV] [Pre-Load] | (Ghost) State when Mega Menu fragment has not loaded (Desktop & Mobile)" (#4210)" This reverts commit 430f850. * Fixed and issue where the gnav popup was emoty on the homepage when switching between mobile and desktop viewports
* Fix for jarvis A11Y issue with tooltip * lint fix --------- Co-authored-by: Dev Ashish Sardana <glo77801@adobe.com>
* [MWPW-171938] - cell role fix * [MWPW-171938] - aria hidden added for empty cells * [MWPW-171938] - revert aria hidden * [MWPW-171938] - shorten code
* [MWPW-173963] - table inside tabs sticky fix * [MWPW-173963] - update logic * [MWPW-173963] - code optimization, variable name change
* fixing advertising and eventmergeid * fixing error * fixing error * fixing error * fixing error * fixing error * fixing error * Adding BACOM properties * Updating DS IDs for BACOM pages * Adding aem * fixing errors * fixing errors * fixing errors * fixing errors * fixing errors * fixing errors --------- Co-authored-by: Akansha Arora <>
play aria fix Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local>
…g feature (#3963) fixed with css
|
Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot |
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
There was a problem hiding this comment.
Unexpected console statement.
Line 796 in e8b6981
…4061) * Gap is seen between promo banner and G-nav when page is scrolled. * move the changes to global navigation css * add min height after 1 second * instead of 100% use 72px as an actually banner height * use --global-height-navPromo instead of static 72px
* WP * WP * wp * Fix a few small issues * Set max length for finishing logs * Remove unused env var * Fix linting issues * add org * Add PR feedback * Add yaml to trigger bacom imports * Always log the first 500 successfully imported live paths * Add EOF (thx Rares) * Dont error if there are no logs * Remove double slack notification * Add Rares feedback
There was a problem hiding this comment.
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.
There was a problem hiding this comment.
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.
* fix fallback deeplink * fix edu * fix * fix cs * fix tests * fix nala&unit tests * fix analytics * fix * fix flacky test * fix another flacky test * add fallback nala test * add test for iframe src
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo:
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale