8000 MWPW-168315 Auto set close captions for videos by g-abani · Pull Request #4314 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-168315 Auto set close captions for videos #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: stage
Choose a base branch
from
Open

MWPW-168315 Auto set close captions for videos #4314

wants to merge 2 commits into from

Conversation

g-abani
Copy link
@g-abani g-abani commented Jun 4, 2025 •
edited by github-actions bot
Loading

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 4, 2025 •
edited
Loading
Page Scores Audits Google
📱 /de/drafts/deeksha/locflow77 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /de/drafts/deeksha/locflow77 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@g-abani g-abani requested a review from overmyheadandbody June 4, 2025 17:19
overmyheadandbody
overmyheadandbody approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor
@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extensive review has been performed in #4288

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 6, 2025

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@spadmasa
Copy link
spadmasa commented Jun 6, 2025 •
edited
Loading

Validation done on the pr on the below urls
https://mwpw-168315--milo--g-abani.aem.page/de/drafts/deeksha/locflow77
image

https://main--bacom--adobecom.aem.page/fr/fragments/drafts/soujanya/plan-create?milolibs=mwpw-168315--milo--g-abani
image
https://main--bacom--adobecom.aem.page/kr/fragments/drafts/soujanya/real-time-customer-data-platform-vs-competitors?milolibs=mwpw-168315--milo--g-abani
image

https://main--bacom--adobecom.aem.page/it/fragments/drafts/soujanya/plan-create?milolibs=mwpw-168315--milo--g-abani
image

fallback to english caption is not seen happening need confirmation on this before we proceed
https://main--bacom--adobecom.aem.page/fr/fragments/drafts/soujanya/real-time-customer-data-platform-vs-competitors?milolibs=mwpw-168315--milo--g-abani

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage and removed verified PR has been E2E tested by a reviewer Ready for Stage labels Jun 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@github-actions GitHub Actions
Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Jun 24, 2025
@spadmasa spadmasa removed the Stale label Jun 25, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jul 3, 2025

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overmyheadandbody overmyheadandbody overmyheadandbody approved these changes

@raga-adbe-gh raga-adbe-gh raga-adbe-gh approved these changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g-abani @spadmasa @overmyheadandbody @raga-adbe-gh
0