8000 MWPW-173816: Adjust addon placement for plans Super wide merch cards by st-angelo-adobe · Pull Request #4334 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-173816: Adjust addon placement for plans Super wide merch cards #4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 13, 2025
Merged

MWPW-173816: Adjust addon placement for plans Super wide merch cards #4334

merged 6 commits into from
Jun 13, 2025

Conversation

st-angelo-adobe
Copy link
Contributor
@st-angelo-adobe st-angelo-adobe commented Jun 6, 2025 •
edited by github-actions bot
Loading

Resolves: MWPW-173816

Test URLs:

Test url:
mwpw-173816--milo--adobecom.aem.page/drafts/astatescu/plans/individual-super-wide

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 6, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 6, 2025 •
edited
Loading
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

github-actions[bot]
github-actions bot reviewed Jun 6, 2025
View reviewed changes
libs/deps/mas/merch-card.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Jun 6, 2025
View reviewed changes
libs/features/mas/dist/mas.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Jun 6, 2025
View reviewed changes
libs/features/mas/src/variants/plans.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Jun 6, 2025
View reviewed changes
libs/features/mas/src/variants/variant-layout.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Jun 6, 2025
View reviewed changes
libs/features/mas/src/hydrate.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Jun 6, 2025
View reviewed changes
libs/features/mas/test/hydrate.test.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

mirafedas
mirafedas approved these changes Jun 6, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

< 8000 div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="C_kwDOHCMjgtoAKDZkNTBmMzczOWVjMjBiNTJhNDc1MTg0ZjgzNmI0MmRkMmMyMDQ4ODA">
@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage labels Jun 11, 2025
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jun 11, 2025

Error merging 4334: MWPW-173816: Adjust addon placement for plans Super wide merch cards Pull Request is not mergeable

@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jun 12, 2025

Error merging 4334: MWPW-173816: Adjust addon placement for plans Super wide merch cards Pull Request is not mergeable

@milo-pr-merge milo-pr-merge bot merged commit b92ca64 into stage Jun 13, 2025
13 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-173816 branch June 13, 2025 08:22
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jun 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Axelcureno Axelcureno Axelcureno approved these changes

@mirafedas mirafedas mirafedas approved these changes

Assignees
No one assigned
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@st-angelo-adobe @Axelcureno @mirafedas @Roycethan
0