8000 [Locv3][Stage] MWPW-173721 A11Y Translation/Rollout selection pill by nkthakur48 · Pull Request #4350 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Locv3][Stage] MWPW-173721 A11Y Translation/Rollout selection pill #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions libs/blocks/locui-create/input-urls/view.js
8000
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,26 @@
Localization${' '}
<span>- ${PROJECT_TYPE_LABELS[type]}</span>
</div>
<div class="locui-form-body">
<div class="locui-form-body"
role="radiogroup"
aria-label="Project Type Selection"
>
${(WORKFLOW[userWorkflowType.value]?.switcher) && html`
<div class="segment-ctrl pb-12">
${[PROJECT_TYPES.translation, PROJECT_TYPES.rollout].map((pType) => html`
<div
key=${pType}
class=${`${type === pType && 'active'}`}
=> handleTypeChange(pType)}
tabindex="0"
role="radio"
aria-checked=${type === pType}
=> {
if (e.key === 'Enter' || e.key === ' ') {

Check failure on line 239 in libs/blocks/locui-create/input-urls/view.js

View workflow job for this annotation

GitHub Actions / Running eslint

[eslint] reported by reviewdog 🐶 Expected indentation of 4 spaces but found 20. Raw Output: {"ruleId":"indent","severity":2,"message":"Expected indentation of 4 spaces but found 20.","line":239,"column":1,"nodeType":"Keyword","messageId":"wrongIndentation","endLine":239,"endColumn":21,"fix":{"range":[6930,6950],"text":" "}}
e.preventDefault();

Check failure on line 240 in libs/blocks/locui-create/input-urls/view.js

View workflow job for this annotation

GitHub Actions / Running eslint

[eslint] reported by reviewdog 🐶 Expected indentation of 6 spaces but found 22. Raw Output: {"ruleId":"indent","severity":2,"message":"Expected indentation of 6 spaces but found 22.","line":240,"column":1,"nodeType":"Identifier","messageId":"wrongIndentation","endLine":240,"endColumn":23,"fix":{"range":[6992,7014],"text":" "}}
handleTypeChange(pType);

Check failure on line 241 in libs/blocks/locui-create/input-urls/view.js

View workflow job for this annotation

GitHub Actions / Running eslint

[eslint] reported by reviewdog 🐶 Expected indentation of 6 spaces but found 22. Raw Output: {"ruleId":"indent","severity":2,"message":"Expected indentation of 6 spaces but found 22.","line":241,"column":1,"nodeType":"Identifier","messageId":"wrongIndentation","endLine":241,"endColumn":23,"fix":{"range":[7034,7056],"text":" "}}
}

Check failure on line 242 in libs/blocks/locui-create/input-urls/view.js

View workflow job for this annotation

GitHub Actions / Running eslint

[eslint] reported by reviewdog 🐶 Expected indentation of 4 spaces but found 20. Raw Output: {"ruleId":"indent","severity":2,"message":"Expected indentation of 4 spaces but found 20.","line":242,"column":1,"nodeType":"Punctuator","messageId":"wrongIndentation","endLine":242,"endColumn":21,"fix":{"range":[7081,7101],"text":" "}}
}}

Check failure on line 243 in libs/blocks/locui-create/input-urls/view.js

View workflow job for this annotation

GitHub Actions / Running eslint

[eslint] reported by reviewdog 🐶 Expected indentation of 2 spaces but found 18. Raw Output: {"ruleId":"indent","severity":2,"message":"Expected indentation of 2 spaces but found 18.","line":243,"column":1,"nodeType":"Punctuator","messageId":"wrongIndentation","endLine":243,"endColumn":19,"fix":{"range":[7103,7121],"text":" "}}
>
${PROJECT_TYPE_LABELS[pType]}
</div>
Expand Down Expand Up @@ -366,4 +378,4 @@
</div>
</div>
`;
}
}

Check failure on line 381 in libs/blocks/locui-create/input-urls/view.js

View workflow job for this annotation

GitHub Actions / Running eslint

[eslint] reported by reviewdog 🐶 Newline required at end of file but not found. Raw Output: {"ruleId":"eol-last","severity":2,"message":"Newline required at end of file but not found.","line":381,"column":2,"nodeType":"Program","messageId":"missing","fix":{"range":[11866,11866],"text":"\n"}}
Loading
0