MWPW-173962: refactor&simplify #4352

3ch023 · 2025-06-10T09:36:13Z

Refactoring as requested on initial PR: #4258 (review)

removed UCv2 support
added more nala tests for 3in1

Test URLs:

aem-code-sync · 2025-06-10T09:36:16Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

912133a ✅ (latest)
b90ea9f ✅
45402c7 ✅
c6cd310 ✅
4cd1f79 ✅
0f0d7a0 ✅
27cedd5 ✅
4a52c67 ✅
560bf3c ✅
49a853a ✅
50825c1 ✅

aem-code-sync · 2025-06-10T09:36:34Z

8000

	Page	Scores	Audits	Google
📱	/drafts/nala/blocks/merch/three-in-one?martech=off
🖥️	/drafts/nala/blocks/merch/three-in-one?martech=off

# Conflicts: # libs/deps/mas/commerce.js # libs/deps/mas/merch-card-collection.js # libs/deps/mas/merch-card.js # libs/deps/mas/merch-offer-select.js # libs/deps/mas/merch-quantity-select.js # libs/deps/mas/merch-sidenav.js # libs/deps/mas/merch-stock.js # libs/features/mas/dist/mas.js # libs/features/mas/src/settings.js

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/4a52c67c06b627438a57a4808a79080305995de5/libs/features/mas/src/constants.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/4a52c67c06b627438a57a4808a79080305995de5/libs/features/mas/src/defaults.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/4a52c67c06b627438a57a4808a79080305995de5/libs/features/mas/src/settings.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/4a52c67c06b627438a57a4808a79080305995de5/libs/features/mas/test/build-checkout-url.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/4a52c67c06b627438a57a4808a79080305995de5/libs/features/mas/test/checkout-button.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/4a52c67c06b627438a57a4808a79080305995de5/libs/features/mas/test/checkout-link.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/4a52c67c06b627438a57a4808a79080305995de5/libs/features/mas/test/checkout.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/4a52c67c06b627438a57a4808a79080305995de5/libs/features/mas/test/mas-commerce-service.test.js

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'CheckoutWorkflow' is defined but never used.

milo/test/blocks/merch/merch.test.js

Line 5 in 4a52c67

    
           import { CheckoutWorkflow, CheckoutWorkflowStep, Defaults, Log } from '../../../libs/deps/mas/commerce.js';

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'CheckoutWorkflow' is defined but never used.

milo/test/blocks/ost/ost.test.html.js

Line 4 in 4a52c67

    
           import { CheckoutWorkflow, CheckoutWorkflowStep } from '../../../libs/deps/mas/commerce.js';

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'CheckoutWorkflowStep' is defined but never used.

milo/test/blocks/ost/ost.test.html.js

Line 4 in 4a52c67

    
           import { CheckoutWorkflow, CheckoutWorkflowStep } from '../../../libs/deps/mas/commerce.js';

github-actions · 2025-06-10T09:40:12Z

libs/deps/mas/commerce.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T09:40:13Z

libs/deps/mas/merch-card-collection.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T09:40:14Z

libs/deps/mas/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T09:40:15Z

libs/deps/mas/merch-offer-select.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T09:40:16Z

libs/deps/mas/merch-quantity-select.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T09:40:17Z

libs/deps/mas/merch-sidenav.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T09:40:18Z

libs/deps/mas/merch-stock.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T09:40:19Z

libs/features/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T09:40:20Z

libs/features/mas/src/buildCheckoutUrl.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T09:40:21Z

libs/features/mas/src/checkout.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'CheckoutWorkflow' is defined but never used.

milo/test/blocks/merch/merch.test.js

Line 5 in 4dfa36d

    
           import { CheckoutWorkflow, CheckoutWorkflowStep, Defaults, Log } from '../../../libs/deps/mas/commerce.js';

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'CheckoutWorkflow' is defined but never used.

milo/test/blocks/ost/ost.test.html.js

Line 4 in 4dfa36d

    
           import { CheckoutWorkflow, CheckoutWorkflowStep } from '../../../libs/deps/mas/commerce.js';

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'CheckoutWorkflowStep' is defined but never used.

milo/test/blocks/ost/ost.test.html.js

Line 4 in 4dfa36d

    
           import { CheckoutWorkflow, CheckoutWorkflowStep } from '../../../libs/deps/mas/commerce.js';

github-actions · 2025-06-10T10:38:44Z

libs/features/mas/src/constants.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T10:38:45Z

libs/features/mas/src/defaults.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T10:38:47Z

libs/features/mas/src/settings.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T10:38:48Z

libs/features/mas/test/build-checkout-url.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T10:38:49Z

libs/features/mas/test/checkout-button.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T10:38:50Z

libs/features/mas/test/checkout-link.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T10:38:51Z

libs/features/mas/test/checkout.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-10T10:38:51Z

libs/features/mas/test/mas-commerce-service.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-06-11T01:55:24Z

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

# Conflicts: # libs/deps/mas/merch-card.js # libs/features/mas/dist/mas.js

# Conflicts: # libs/deps/mas/commerce.js # libs/deps/mas/merch-card-collection.js # libs/deps/mas/merch-card.js # libs/deps/mas/merch-quantity-select.js # libs/deps/mas/merch-sidenav.js # libs/features/mas/dist/mas.js

github-actions · 2025-06-17T12:40:06Z

libs/features/mas/test/hydrate.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

# Conflicts: # libs/deps/mas/commerce.js # libs/deps/mas/merch-card-collection.js # libs/deps/mas/merch-card.js # libs/features/mas/dist/mas.js # libs/features/mas/test/mas-commerce-service.test.js

milo-pr-merge · 2025-06-23T09:21:53Z

Error merging 4352: MWPW-173962: refactor&simplify Pull Request is not mergeable

# Conflicts: # libs/deps/mas/merch-card-collection.js # libs/deps/mas/merch-card.js # libs/deps/mas/merch-stock.js # libs/features/mas/dist/mas.js

3ch023 added 3 commits June 10, 2025 10:04

MWPW-173962: refactor&simplify

50825c1

add full nala coverage for fallback

49a853a

add nala tests for catalog deeplink

560bf3c

3ch023 requested a review from a team as a code owner June 10, 2025 09:36

3ch023 added the commerce label Jun 10, 2025

aem-code-sync bot temporarily deployed to MWPW-173962-refactor June 10, 2025 09:39 Inactive

github-actions bot reviewed Jun 10, 2025

View reviewed changes

aem-code-sync bot temporarily deployed to MWPW-173962-refactor June 10, 2025 10:38 Inactive

github-actions bot reviewed Jun 10, 2025

View reviewed changes

add checkout unit test

27cedd5

3ch023 force-pushed the MWPW-173962-refactor branch from 4dfa36d to 27cedd5 Compare June 10, 2025 10:45

aem-code-sync bot temporarily deployed to MWPW-173962-refactor June 10, 2025 10:45 Inactive

fix lint issues

0f0d7a0

aem-code-sync bot temporarily deployed to MWPW-173962-refactor June 10, 2025 10:54 Inactive

bozojovicic approved these changes Jun 10, 2025

View reviewed changes

mirafedas approved these changes Jun 10, 2025

View reviewed changes

yesil approved these changes Jun 11, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/stage' into MWPW-173962-refactor

4cd1f79

# Conflicts: # libs/deps/mas/merch-card.js # libs/features/mas/dist/mas.js

aem-code-sync bot temporarily deployed to MWPW-173962-refactor June 12, 2025 08:46 Inactive

aem-code-sync bot temporarily deployed to MWPW-173962-refactor June 17, 2025 12:37 Inactive

fix unit test

45402c7

github-actions bot reviewed Jun 17, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/stage' into MWPW-173962-refactor

b90ea9f

# Conflicts: # libs/deps/mas/commerce.js # libs/deps/mas/merch-card-collection.js # libs/deps/mas/merch-card.js # libs/features/mas/dist/mas.js # libs/features/mas/test/mas-commerce-service.test.js

aem-code-sync bot temporarily deployed to MWPW-173962-refactor June 20, 2025 09:59 Inactive

afmicka added verified PR has been E2E tested by a reviewer Ready for Stage labels Jun 20, 2025

Merge remote-tracking branch 'upstream/stage' into MWPW-173962-refactor

912133a

# Conflicts: # libs/deps/mas/merch-card-collection.js # libs/deps/mas/merch-card.js # libs/deps/mas/merch-stock.js # libs/features/mas/dist/mas.js

aem-code-sync bot deployed to MWPW-173962-refactor June 23, 2025 11:19 View deployment

milo-pr-merge bot merged commit 53a6a5a into stage Jun 23, 2025
13 checks passed

milo-pr-merge bot deleted the MWPW-173962-refactor branch June 23, 2025 11:35

github-actions bot mentioned this pull request Jun 23, 2025

[Release] Stage to Main #4447

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MWPW-173962: refactor&simplify #4352

MWPW-173962: refactor&simplify #4352

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MWPW-173962: refactor&simplify #4352

MWPW-173962: refactor&simplify #4352

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!