emea1443 mweb design tweaks #4378
Conversation
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
|
| @@ -375,7 +381,7 @@ html[dir="rtl"] .carousel .move-indicators { | |||
| background-color: rgb(255 255 255 / 95%); | |||
| } | |||
|
|
|||
| .carousel.lightbox .carousel-expand:focus-visible > img { | |||
| .carousel.lightbox .carousel-expand:focus-visible>img { | |||
There was a problem hiding this comment.
Are all these little adjustments needed? Not sure I agree with removing the space here. Makes it more difficult to read.
There was a problem hiding this comment.
Reverted those changes.
| .carousel[class*='show-'] .carousel-slide .foreground { width: auto; } | ||
| .carousel[class*='show-'] .carousel-slide .foreground { | ||
| width: auto; | ||
| } |
There was a problem hiding this comment.
Is linting complaining about this?
There was a problem hiding this comment.
Reverted this as well.
| @@ -20,11 +20,11 @@ main .collapsible-card-wrapper .collapsible-card .header h3, | |||
| main .collapsible-card-wrapper .collapsible-card .header h4, | |||
| main .collapsible-card-wrapper .collapsible-card .header h5, | |||
| main .collapsible-card-wrapper .collapsible-card .header h6 { | |||
| text-align: center; | |||
| text-align: left; | |||
There was a problem hiding this comment.
Specific alignment for left causes problems in RTL languages.
text-align: start or text-align: end is a much better approach to not run into language direction problems.
There was a problem hiding this comment.
Implemented this suggestion
| justify-content: center; | ||
| /* min-height: 60px; */ | ||
| /* align-items: center; | ||
| justify-content: center; */ |
There was a problem hiding this comment.
Delete commented out code.
There was a problem hiding this comment.
Done
Marked high priority because it is a blocker for a test launch.
Mweb changes for emea1443 which adds two repurposed express blocks and adds a bunch of classes/some functions to existing milo blocks.
These blocks are tweaked
Resolves: EMEA1443
Test URLs:
Before: https://www.adobe.com/uk/creativecloud/buy/students.html
After: https://main--cc--adobecom.aem.page/cc-shared/fragments/tests/emea-latam/2025/q2/emea1443/fragments/mweb-page?milolibs=emea1443-mweb&mep=%2Fcc-shared%2Ffragments%2Ftests%2Femea-latam%2F2025%2Fq2%2Femea1443%2Fmep%2F1443-ste-mweb.json--target-variant
Psi-check: https://emea1443-mweb--milo--adobecom.aem.page/?martech=off