MWPW-174735 [Milo][Analytics] Tabs do not have a daa-lh attribute on the block #4379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
vgoodric
approved these changes
Jun 12, 2025
denlight
approved these changes
Jun 12, 2025
|
Reminder to set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decorateSectionAnalytics function is skipping over the tabs block when adding the main, block-level daa-lh value because it (and Milo generally) does not expect blocks to exist within blocks. This PR adds the daa-lh value to tabs by making an exception for the tabs block.
Resolves: MWPW-174735
Steps to QA:
check before and after links below for the daa-lh value for tabs.
Expected (After): daa-lh --> 'b1|tabs|nopzn|plans-pzn'
Actual (Before): no daa-lh value
Test URLs: