8000 MWPW-174906: adds playVideo string to config.collection.i10n by cmiqueo · Pull Request #4391 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-174906: adds playVideo string to config.collection.i10n #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2025
Merged

MWPW-174906: adds playVideo string to config.collection.i10n #4391

merged 4 commits into from
Jun 16, 2025

Conversation

cmiqueo
Copy link
Contributor
@cmiqueo cmiqueo commented Jun 12, 2025 •
edited by github-actions bot
Loading

Description
Currently aria-label description for play video buttons are hardcoded in english.

This PR allows for the aria-label string to be translated by adding a new 'playVideo' string to config.collection.i10n

Resolves: MWPW-174906

Test URL:

@cmiqueo cmiqueo requested a review from chrischrischris as a code owner June 12, 2025 14:37
@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 12, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 12, 2025 •
edited
Loading
Page Scores Audits Google
📱 /drafts/cmiqueo/test-page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/cmiqueo/test-page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cmiqueo cmiqueo self-assigned this Jun 12, 2025
@cmiqueo cmiqueo added caas-configurator CaaS Configurator CaaS CaaS related code labels Jun 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@cmiqueo cmiqueo mentioned this pull request Jun 13, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@milo-pr-merge milo-pr-merge bot merged commit b608b29 into stage Jun 16, 2025
17 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-174906 branch June 16, 2025 20:18
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukamat sukamat sukamat approved these changes

@sheridansunier sheridansunier sheridansunier approved these changes

@shkhan91 shkhan91 shkhan91 approved these changes

@jedjedjedM jedjedjedM Awaiting requested review from jedjedjedM

@gmirijan gmirijan Awaiting requested review from gmirijan

@chrischrischris chrischrischris Awaiting requested review from chrischrischris chrischrischris is a code owner

Assignees

@cmiqueo cmiqueo

Labels
CaaS CaaS related code caas-configurator CaaS Configurator Ready for Stage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmiqueo @sukamat @sheridansunier @shkhan91
0