Rolling importer fixes #4413
Rolling importer fixes #4413
Conversation
|
| @@ -0,0 +1,3 @@ | |||
| export default [ | |||
There was a problem hiding this comment.
Compared to localPathsToImport, which actually, when set, would import those specific paths.
There was a problem hiding this comment.
Would it make sense to have these notes as a comment in the file itself, so whoever runs the script knows which to use?
There was a problem hiding this comment.
I'm still not clear about the difference between the two files. I see localPathsToImport is used to read from it, while importingPaths is used to write in it.
There was a problem hiding this comment.
I tried to add a more elaborate explanation... You're right, localPathsToImport is being read and we only import those articles. Handy for tracking down failures and debugging specific imports.
There was a problem hiding this comment.
The now named paths-that-are-being-currently-imported file, just shows whatever is being imported. Based on logs, or local file.
Comes in handy when the logs have certain articles that were 'previewed' but not published, so it avoids any confusion
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
| @@ -0,0 +1,3 @@ | |||
| export default [ | |||
There was a problem hiding this comment.
Would it make sense to have these notes as a comment in the file itself, so whoever runs the script knows which to use?
2192fb4 to
0586f2e
Compare
36b4b0d to
d92a1b0
Compare
Description
Due to network flakiness, a few requests can timeout leading to articles not being successfully imported. We can have some very simplified "retry" logic here, to retry once, which should bring down failures to close to 0. It's manual effort for me to import any straddlers, hopefully can be avoided with this already.
Also added a from-to date for easier tracking of the exact calls we make to the AEM APIs and allowing to set more params locally to simulate a workflow run for debugging purposes.
Test URLs: