8000 MWPW-174674: Added email-collection block by zagi25 · Pull Request #4424 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
< 8000 div hidden="hidden" data-view-component="true" class="js-stale-session-flash stale-session-flash flash flash-warn flash-full"> Dismiss alert

MWPW-174674: Added email-collection block #4424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

zagi25
Copy link
Contributor
@zagi25 zagi25 commented Jun 17, 2025

email-collection block.

Current implementation:
email-collection has two variants (default and large-image). Authoring is similar to marquee block with the addition of another row that contains the success message text. (Missing success message row, will break the form)
Form config is authored via email-collection-metadata block (missing email-collection-metadata block will break the form).
Fields:

  • email: Label
  • first-name: Label
  • last-name: Label
  • organization: Label
  • occupation: Label
  • state: Label | url
  • country: Label | url
  • custom: Label

Field names are mapped in the code, so if added field name is not found, it will be ignored. Also field attributes are hardcoded, I did this because we already know what fields are accepted by the backend and what is required. Only thing that can be authored is field label with an exception of state and country, these are select fields and author must provide url to the excel sheet with values.

Config

  • consent-string : value
  • consent-id : value
  • campaign-id : value
  • mps-sname : value

Config part contains values needed for the backend, and if one of the values is missing form will break.
Names for this may change depending of what is exactly expected on the backend.

Select input is localized:
Screenshot 2025-06-30 at 13 27 53
Screenshot 2025-06-30 at 13 28 02
Germany page

Tablet design is missing so I just expanded mobile view until 1200px.

Questions:

  1. For accessibility, heading must be present in the modal. Some of the designs don't have heading, what is the best approach here, tell them that heading must be present or style the heading like the text so it can be used instead of regular text (if only heading is present) ?
  2. Success message has a button Back to the website currently this is just a link to the page without modal hash, should I leave it this way or add actual button that will just close the modal (prevent reload of the page) ?

Designs:

Resolves: MWPW-174674

NOTE: Clicking on marquee buttons will open form.
Test URLs:

@zagi25 zagi25 requested a review from a team June 17, 2025 13:41
Copy link
Contributor
aem-code-sync bot commented Jun 17, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor
aem-code-sync bot commented Jun 17, 2025

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor
@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to set CODEOWNERS for this new block 😁

Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Jun 26, 2025
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-174674-email-configurator June 30, 2025 11:13 Inactive
@zagi25 zagi25 marked this pull request as ready for review June 30, 2025 11:57
@zagi25 zagi25 requested a review from a team June 30, 2025 11:57
@zagi25 zagi25 removed the Stale label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0