-
Notifications
You must be signed in to change notification settings - Fork 190
MWPW-174674: Added email-collection block #4424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to set CODEOWNERS for this new block 😁
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
email-collection
block.Current implementation:
email-collection
has two variants (default andlarge-image
). Authoring is similar tomarquee
block with the addition of another row that contains the success message text. (Missing success message row, will break the form)Form config is authored via
email-collection-metadata
block (missingemail-collection-metadata
block will break the form).Fields:
Field names are mapped in the code, so if added field name is not found, it will be ignored. Also field attributes are hardcoded, I did this because we already know what fields are accepted by the backend and what is required. Only thing that can be authored is field
label
with an exception ofstate
andcountry
, these are select fields and author must provide url to the excel sheet with values.Config
Config part contains values needed for the backend, and if one of the values is missing form will break. Names for this may change depending of what is exactly expected on the backend.
Select input is localized:


Germany page
Tablet design is missing so I just expanded mobile view until 1200px.
Questions:
Back to the website
currently this is just a link to the page without modal hash, should I leave it this way or add actual button that will just close the modal (prevent reload of the page) ?Designs:
Resolves: MWPW-174674
NOTE: Clicking on marquee buttons will open form.
Test URLs: