10000 [MWPW-175193] Remove programmatic headings from table by overmyheadandbody · Pull Request #4432 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MWPW-175193] Remove programmatic headings from table #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

[MWPW-175193] Remove programmatic headings from table #4432

merged 1 commit into from
Jun 23, 2025

Conversation

overmyheadandbody
Copy link
Contributor
@overmyheadandbody overmyheadandbody commented Jun 18, 2025 •
edited by github-actions bot
Loading

This is fundamentally a revert of #4276, for which a faulty fix was applied based on a wrong interpretation of a JIRA requirement. The issue brought up in that story had been fixed in #4248 / https://jira.corp.adobe.com/browse/MWPW-171938 by @DKos95.

This is marked as high priority as it relates to accessibility, for which there is a tight deadline of June 28th. The JIRA story reflects its urgency as well.

Resolves: MWPW-175193

Test URLs:

@overmyheadandbody overmyheadandbody added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Jun 18, 2025
@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 18, 2025
Page Scores Audits Google
📱 /docs/library/kitchen-sink/table?martech=off&georouting=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /docs/library/kitchen-sink/table?martech=off&georouting=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@github-actions GitHub Actions
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@SilviuLCF SilviuLCF self-requested a review June 20, 2025 07:15
SilviuLCF
SilviuLCF approved these changes Jun 20, 2025
View reviewed changes
Copy link
@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, testing details
https://jira.corp.adobe.com/browse/MWPW-175193

@milo-pr-merge milo-pr-merge bot merged commit 8f2cdb9 into adobecom:stage Jun 23, 2025
21 of 23 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilviuLCF SilviuLCF SilviuLCF approved these changes

@zagi25 zagi25 zagi25 approved these changes

@DKos95 DKos95 DKos95 approved these changes

@aishwaryamathuria aishwaryamathuria Awaiting requested review from aishwaryamathuria

Assignees
No one assigned
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overmyheadandbody @SilviuLCF @zagi25 @DKos95
0