8000 MWPW-175459: adds new strings for localization by cmiqueo · Pull Request #4464 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-175459: adds new strings for localization #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: stage
Choose a base branch
from
Open

MWPW-175459: adds new strings for localization #4464

wants to merge 4 commits into from
+10 −0

Conversation

cmiqueo
Copy link
Contributor
@cmiqueo cmiqueo commented Jun 24, 2025 •
edited by sanrai
Loading

Description:
Adds new strings for localization. Carousel Next and Previous buttons need a localized aria-label string

Resolves:
MWPW-175459

URL for testing:

Note:
For some reason, changes to the description do not trigger a re-test.

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 24, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@cmiqueo cmiqueo self-assigned this Jun 24, 2025
@cmiqueo cmiqueo added caas-configurator CaaS Configurator CaaS CaaS related code Ready for Stage labels Jun 24, 2025
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jun 25, 2025

Skipped merging 4464: MWPW-175459: adds new strings for localization due to failing or running checks

@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jun 26, 2025

Skipped merging 4464: MWPW-175459: adds new strings for localization due to failing or running checks

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 26, 2025 •
edited
Loading
Page Scores Audits Google
📱 /drafts/sanrai/foo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/sanrai/foo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cmiqueo cmiqueo mentioned this pull request Jun 26, 2025
Merged
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jul 5, 2025

Skipped merging 4464: MWPW-175459: adds new strings for localization due to failing or running checks

3 similar comments
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jul 6, 2025

Skipped merging 4464: MWPW-175459: adds new strings for localization due to failing or running checks

@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jul 7, 2025

Skipped merging 4464: MWPW-175459: adds new strings for localization due to failing or running checks

@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jul 8, 2025

Skipped merging 4464: MWPW-175459: adds new strings for localization due to failing or running checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischrischris chrischrischris chrischrischris approved these changes

@sheridansunier sheridansunier sheridansunier approved these changes

@shkhan91 shkhan91 shkhan91 approved these changes

@sanrai sanrai Awaiting requested review from sanrai sanrai is a code owner

@gmirijan gmirijan Awaiting requested review from gmirijan

Assignees

@cmiqueo cmiqueo

Labels
CaaS CaaS related code caas-configurator CaaS Configurator Ready for Stage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmiqueo @chrischrischris @sheridansunier @shkhan91
0