8000 [Release] Stage to Main by milo-pr-merge[bot] · Pull Request #4466 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Release] Stage to Main #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 27, 2025
Merged

[Release] Stage to Main #4466

merged 14 commits into from
Jun 27, 2025

Conversation

milo-pr-merge[bot]
Copy link
Contributor
@milo-pr-merge milo-pr-merge bot commented Jun 25, 2025 •
edited by github-actions bot
Loading

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

@milo-pr-merge
Copy link
Contributor Author
milo-pr-merge bot commented Jun 25, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot @adobecom/blog-sot

@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner June 25, 2025 11:28
@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 25, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@github-actions GitHub Actions
Copy link
Contributor

SNOW Change Request Transaction ID: 0000019746cb9d8a-289e5b9

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 25, 2025 •
edited
Loading
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@mokimo mokimo temporarily deployed to milo_pr_merge June 25, 2025 12:35 — with GitHub Actions Inactive
@afmicka afmicka temporarily deployed to milo_pr_merge June 25, 2025 13:14 — with GitHub Actions Inactive
@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner June 25, 2025 13:14
@mokimo mokimo temporarily deployed to milo_pr_merge June 25, 2025 16:21 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 25, 2025 20:18 — with GitHub Actions Inactive
@Dli3
Copy link
Dli3 commented Jun 25, 2025

Hi @overmyheadandbody , I'm able to tab to the action scroller, but there's no focus indicator displayed for the element on Safari and Firefox.

Also, the focus indicator doesn't display the left and right borders on Chrome.
Screenshot 2025-06-25 at 3 03 56 PM

Test page: https://main--da-bacom--adobecom.aem.live/products/firefly-business?martech=off&milolibs=stage

cc @SilviuLCF

@mokimo mokimo temporarily deployed to milo_pr_merge June 26, 2025 01:21 — with GitHub Actions Inactive
@chrischrischris
MWPW-175169 Fix gb-changed highlighting; Add overlay toggle (#4462)
f6eda3b 
* MWPW-175169 Fix gb-changed highlighting

* Add ability to toggle the gray overlay on/off
@milo-pr-merge milo-pr-merge bot requested a review from colloyd as a code owner June 26, 2025 01:21
@vgoodric
MWPW-175550 [MMM][MEP] Updates to metada-optimization json does not a…
979555b 
…lways reflect in MMM (#4463)

Add random query parameter to metadata URL for uniqueness
@milo-pr-merge milo-pr-merge bot requested a review from vgoodric as a code owner June 26, 2025 01:21
@mokimo mokimo temporarily deployed to milo_pr_merge June 26, 2025 04:26 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 26, 2025 08:23 — with GitHub Actions Inactive
@hit11757
[MWPW-173101][NALA] Automation test script for ReadingTime block (#4385)
2f95660 
MWPW-173101 Automation test script for ReadingTime block
@mokimo mokimo temporarily deployed to milo_pr_merge June 26, 2025 09:19 — with GitHub Actions Inactive
@overmyheadandbody
Copy link
Contributor

Hey @Dli3! Thanks for noticing that! This is a bit of a perfect storm - the block is not intended to be used without links inside of it; additionally, axe falsely flags this as a problem - dequelabs/axe-core#4788. In reality, the section does not need to be focusable for accessibility purposes, but Chrome and Firefox automatically focus scrollable elements without inner focusable elements of their own. Safari has a different implementation which is, indeed, affected by this change. There's no simple way of solving this and I wouldn't want to invest too much time in a solution, since it is:

  • arising from an edge case, since the block is not used as intended;
  • not an actual accessibility bug, as confirmed by the axe developers;
  • not included in the scope of EAA, since it's a business page, not a B2C one.

So we have two options:

  • revert that PR and decide we can live with the axe error until they fix it on their side;
  • leave the PR in and accept the slightly degraded experience on Safari, which is now closer to that on Chrome and Firefox

What are your thoughts?

CC: @SilviuLCF

@mokimo mokimo temporarily deployed to milo_pr_merge June 26, 2025 12:35 — with GitHub Actions Inactive
@hit11757
[MWPW-173103][NALA] Automation test script for Mnemonic List (#4470)
0164a84 
MWPW-173103 Automation test script for Mnemonic List
@Dli3 Dli3 temporarily deployed to milo_pr_merge June 26, 2025 21:24 — with GitHub Actions Inactive
@Dli3 Dli3 temporarily deployed to milo_pr_merge June 26, 2025 21:24 — with GitHub Actions Inactive
@yesil
MWPW-175654: preload ucv3 script (#4477)
02b63cf 
* MWPW-175654: preload ucv3 script

ucv3 script doesn't support modern preload
and requires an id attribute on the script element
therefore we need to use loadScript instead of loadLink

* add defer

* use window.milo.deferredPromise
@mokimo mokimo temporarily deployed to milo_pr_merge June 27, 2025 01:22 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 27, 2025 04:25 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 27, 2025 08:22 — with GitHub Actions Inactive
@zagi25
Mwpw 174987 hero marquee order (#4475)
7fde595 
* MWPW-174987: Change DOM order of elements based on viewport

* MWPW-174987: Add additional check

* MWPW-174987: PR feedback

* MWPW-174987: Fix no-order els bug

* MWPW-174987: Fix no desktop bug

* MWPW-174987: Update unit tests

* MWPW-174987: Fix

* MWPW-174987: Remove previous
@mokimo mokimo temporarily deployed to milo_pr_merge June 27, 2025 09:18 — with GitHub Actions Inactive
afmicka
afmicka requested changes Jun 27, 2025
View reviewed changes
Copy link
Contributor
@afmicka afmicka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are seeing issues with CTAs on https://main--cc--adobecom.aem.page/creativecloud/plans?milolibs=stage. Need to investigate if other pages are affected as well

sigadamvenkata
sigadamvenkata requested changes Jun 27, 2025
View reviewed changes
Copy link
@sigadamvenkata sigadamvenkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we came across below issue. kindly look into it
https://jira.corp.adobe.com/browse/MWPW-175705

@3ch023
Copy link
Contributor
3ch023 commented Jun 27, 2025

we came across below issue. kindly look into it https://jira.corp.adobe.com/browse/MWPW-175705

checked the issue, it is caused by content, not code. reported in #milo-community

sigadamvenkata
sigadamvenkata approved these changes Jun 27, 2025
View reviewed changes
Copy link
@sigadamvenkata sigadamvenkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned issue was a OST parameter issues which is not configured in STAGE properly. so approving PR

@overmyheadandbody overmyheadandbody merged commit 98dd7b7 into main Jun 27, 2025
19 of 20 checks passed
@mokimo mokimo temporarily deployed to milo_pr_merge June 27, 2025 12:34 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 27, 2025 16:20 — with GitHub Actions Inactive
@mokimo mokimo temporarily deployed to milo_pr_merge June 27, 2025 20:18 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afmicka afmicka afmicka approved these changes

@Dli3 Dli3 Dli3 approved these changes

@sigadamvenkata sigadamvenkata sigadamvenkata approved these changes

@hit11757 hit11757 hit11757 approved these changes

@colloyd colloyd Awaiting requested review from colloyd

@vgoodric vgoodric Awaiting requested review from vgoodric vgoodric is a code owner

Assignees
No one assigned
Labels
BAcom SOT 👌 Blog SOT 👌 CC SOT 👌 MIQ SOT👌
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0