8000 MWPW-173845: Fix collection header margin for edu plans cards by st-angelo-adobe · Pull Request #4467 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-173845: Fix collection header margin for edu plans cards #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

st-angelo-adobe
Copy link
Contributor
@st-angelo-adobe st-angelo-adobe commented Jun 25, 2025

The margin top for plans cards with no mnemonics was being applied to edu cards as well, which have no mnemonics. Check the Schools & Universities tab in the cc page.

Resolves: MWPW-173845

Test URL:

CC page: https://main--cc--adobecom.aem.page/creativecloud/plans?milolibs=mwpw-173845--milo--adobecom&plan=edu_inst

@st-angelo-adobe st-angelo-adobe requested a review from a team as a code owner June 25, 2025 11:47
Copy link
Contributor
aem-code-sync bot commented Jun 25, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor
aem-code-sync bot commented Jun 25, 2025
Page Scores Audits Google
📱 /drafts/npeltier/plans?mertech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/npeltier/plans?mertech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@st-angelo-adobe st-angelo-adobe changed the base branch from stage to plans June 30, 2025 09:54
@afmicka afmicka added the verified PR has been E2E tested by a reviewer label Jul 1, 2025
@3ch023 3ch023 merged commit 74d04b3 into plans Jul 1, 2025
16 checks passed
@3ch023 3ch023 deleted the MWPW-173845 branch July 1, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0