8000 Updating popup position after decoration by bandana147 · Pull Request #4506 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updating popup position after decoration #4506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: stage
Choose a base branch
from
Open

Updating popup position after decoration #4506

wants to merge 2 commits into from

Conversation

bandana147
Copy link
Contributor
@bandana147 bandana147 commented Jul 7, 2025 •
edited by github-actions bot
Loading
  • When ghost state is present the updatePopupPosition applies the style top to loading popup
  • The style top has to be applied on the actual popup as well

Resolves: MWPW-175954

Test URLs:

QA:

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

@bandana147 bandana147 added the needs-verification PR requires E2E testing by a reviewer label Jul 7, 2025
@bandana147 bandana147 requested a review from a team as a code owner July 7, 2025 09:12
@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jul 7, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jul 7, 2025 •
edited
Loading
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spadmasa spadmasa

@prativas22 prativas22

Labels
needs-verification PR requires E2E testing by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bandana147 @spadmasa @prativas22
0