MWPW-169236 [Merch Cards] Support for Volume Discount Flex Promos #4501
+263
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added 4 commits
July 4, 2025 11:23
yesil
requested changes
Jul 7, 2025
|
|
||
| const price = this.prices[0]; | ||
| if (this.quantityBasedPromo?.resolved && this.quantityBasedPromo?.promotionCode && price) { | ||
| if (event.detail.option >= this.quantityBasedPromo.minProductQuantity) { |
There was a problem hiding this comment.
I think the whole promo min quantity logic should move in checkout-mixin.
I don't understand the intent here. Promo code should remain on checkout links irrespective of the quantity. It belongs checkout page to apply or not the promo based on the quantity.
There was a problem hiding this comment.
Ok @yesil I will add the question to the ticket if CTAs should be affected by this change or commerce will handle it. Maybe it's not needed for CTAs. The more I ready the ticket description the less I'm sure. If it's needed, I will see how to move the logic to checkout-mixin.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For merch cards with prices with promos where the offer has minProductQuantity > 1 I added the support for these promotions based on selected value in the quantity selector. If such price with promo is not in the card or quantity selector is not there, nothing will change. If they are both there and the selected quantity is >= minProductQuantity then :
apcparameter with the promo code if that CTA is authored with that promo codeIf the selected quantity is < minProductQuantity then :
apcparameter anddata-promotion-codeattribute (if that CTA is authored with that promo code)I added unit tests where all this is simulated.
Resolves: MWPW-169236
Test URLs: